From: Miklos Vajna <vmiklos@frugalware.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Bj?rn Steinbrink <B.Steinbrink@gmx.de>,
git@vger.kernel.org
Subject: Re: [PATCH 0/4] add pre-auto-gc hook for git-gc --auto (try2)
Date: Wed, 2 Apr 2008 03:14:47 +0200 [thread overview]
Message-ID: <20080402011447.GO3264@genesis.frugalware.org> (raw)
In-Reply-To: <7vhceldv12.fsf@gitster.siamese.dyndns.org>
[-- Attachment #1: Type: text/plain, Size: 769 bytes --]
On Tue, Apr 01, 2008 at 04:18:01PM -0700, Junio C Hamano <gitster@pobox.com> wrote:
> > - removed unnecessary stdout_to_stderr from builtin-gc.c::run_hook()
>
> Wait, a, minute, please. Not so fast. I did not say "I think this is
> wrong, please fix it".
>
> I only asked why it is so.
>
> Care to explain why it was thought to be necessary, and why you now think
> it is unnecessary?
Ok, let me explain. I think it would be logical to put it to stderr, as
the other gc --auto messages are there, as well. See the fprintf() in
cmd_gc().
Though, I don't think it's that important, so I thought if you think
it's unnecessary, I would not argue for it.
So may I put it back? :)
Also, is the other parts of the series looks correct?
Thanks
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2008-04-02 1:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <7637ee64f43964d2e514c1598b2e7783d71b8608.1206929014.git.vmiklos @frugalware.org>
2008-04-01 4:51 ` [PATCH 1/4] git-gc --auto: add pre-auto-gc hook Junio C Hamano
2008-04-01 11:38 ` [PATCH 0/4] add pre-auto-gc hook for git-gc --auto (try2) Miklos Vajna
2008-04-01 23:18 ` Junio C Hamano
2008-04-02 1:14 ` Miklos Vajna [this message]
2008-04-02 4:02 ` Junio C Hamano
2008-04-02 19:02 ` Miklos Vajna
2008-04-02 19:07 ` Junio C Hamano
2008-04-02 19:34 ` [PATCH 0/3] add pre-auto-gc hook for git-gc --auto (try3) Miklos Vajna
2008-04-02 19:34 ` [PATCH 1/3] git-gc --auto: add pre-auto-gc hook Miklos Vajna
2008-04-02 19:34 ` [PATCH 2/3] Documentation/hooks: " Miklos Vajna
2008-04-02 19:35 ` [PATCH 3/3] contrib/hooks: add an example " Miklos Vajna
2008-04-02 19:49 ` Junio C Hamano
2008-04-02 20:22 ` Miklos Vajna
2008-04-02 20:34 ` Junio C Hamano
2008-04-02 20:45 ` Miklos Vajna
2008-04-03 21:26 ` tests for pre-auto-gc hook (WAS: Re: [PATCH 3/3] contrib/hooks: add an example pre-auto-gc hook) Miklos Vajna
2008-04-04 6:34 ` tests for pre-auto-gc hook Johannes Sixt
2008-04-01 11:39 ` [PATCH 1/4] git-gc --auto: add " Miklos Vajna
2008-04-01 11:39 ` [PATCH 2/4] Documentation/hooks: " Miklos Vajna
2008-04-01 11:39 ` [PATCH 3/4] templates: add an example " Miklos Vajna
2008-04-01 11:39 ` [PATCH 4/4] contrib/hooks: " Miklos Vajna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080402011447.GO3264@genesis.frugalware.org \
--to=vmiklos@frugalware.org \
--cc=B.Steinbrink@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).