From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Jan Engelhardt <jengelh@computergmbh.de>
Subject: [PATCH] format-patch: set default stat_width to 72
Date: Thu, 3 Apr 2008 06:22:14 -0400 [thread overview]
Message-ID: <20080403102214.GA23121@coredump.intra.peff.net> (raw)
The usual default is 80, which should fit in the terminals
of most users. However, it is usually considered polite to
keep email lines to 72 characters to accomodate a few layers
of quoting.
Signed-off-by: Jeff King <peff@peff.net>
---
On Thu, Apr 03, 2008 at 06:14:18AM -0400, Jeff King wrote:
> format-patch already defaults to "--stat --summary -p" if you give it
> no format options. The default stat is 80, I believe; for format-patch
> it should probably be bumped to 72 anyway.
This should be totally harmless and maint-worthy, I would think.
builtin-log.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/builtin-log.c b/builtin-log.c
index 5c00725..8d7b975 100644
--- a/builtin-log.c
+++ b/builtin-log.c
@@ -771,6 +771,7 @@ int cmd_format_patch(int argc, const char **argv, const char *prefix)
rev.ignore_merges = 1;
rev.diffopt.msg_sep = "";
DIFF_OPT_SET(&rev.diffopt, RECURSIVE);
+ rev.diffopt.stat_width = 72;
rev.subject_prefix = fmt_patch_subject_prefix;
--
1.5.5.rc2.171.g7962.dirty
next reply other threads:[~2008-04-03 10:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-03 10:22 Jeff King [this message]
2008-04-04 6:12 ` [PATCH] format-patch: set default stat_width to 72 Junio C Hamano
2008-04-04 10:50 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080403102214.GA23121@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jengelh@computergmbh.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).