git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Couder <chriscool@tuxfamily.org>
To: Junio Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: [PATCH] test suite: remove useless TERM cruft in "t7005-editor.sh"
Date: Sun, 6 Apr 2008 19:08:50 +0200	[thread overview]
Message-ID: <20080406190850.e7a13c3c.chriscool@tuxfamily.org> (raw)

In commit 15387e32ff5116b82d3fe53df55b8c87eec83e01 I added some cruft
to reset TERM to its previous value before the "test_done" at the end
of "t7005-editor.sh" because otherwise "test_done" would have printed
the test result with a bad TERM env variable (this resulted in output
with no color on konsole).

But since commit c2116a1783a3d555d41892ae7db0dd0934d4ddf1 colored
output is printed in a subshell with TERM reset to its original value
so the cruft added in my patch above is now useless.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 t/t7005-editor.sh |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/t/t7005-editor.sh b/t/t7005-editor.sh
index 6a74b3a..2d919d6 100755
--- a/t/t7005-editor.sh
+++ b/t/t7005-editor.sh
@@ -4,8 +4,6 @@ test_description='GIT_EDITOR, core.editor, and stuff'
 
 . ./test-lib.sh
 
-OLD_TERM="$TERM"
-
 for i in GIT_EDITOR core_editor EDITOR VISUAL vi
 do
 	cat >e-$i.sh <<-EOF
@@ -116,6 +114,4 @@ test_expect_success 'core.editor with a space' '
 
 '
 
-TERM="$OLD_TERM"
-
 test_done
-- 
1.5.5.rc2.20.g03f57.dirty

                 reply	other threads:[~2008-04-06 17:04 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080406190850.e7a13c3c.chriscool@tuxfamily.org \
    --to=chriscool@tuxfamily.org \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).