git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] test suite: remove useless TERM cruft in "t7005-editor.sh"
@ 2008-04-06 17:08 Christian Couder
  0 siblings, 0 replies; only message in thread
From: Christian Couder @ 2008-04-06 17:08 UTC (permalink / raw)
  To: Junio Hamano; +Cc: git

In commit 15387e32ff5116b82d3fe53df55b8c87eec83e01 I added some cruft
to reset TERM to its previous value before the "test_done" at the end
of "t7005-editor.sh" because otherwise "test_done" would have printed
the test result with a bad TERM env variable (this resulted in output
with no color on konsole).

But since commit c2116a1783a3d555d41892ae7db0dd0934d4ddf1 colored
output is printed in a subshell with TERM reset to its original value
so the cruft added in my patch above is now useless.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 t/t7005-editor.sh |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/t/t7005-editor.sh b/t/t7005-editor.sh
index 6a74b3a..2d919d6 100755
--- a/t/t7005-editor.sh
+++ b/t/t7005-editor.sh
@@ -4,8 +4,6 @@ test_description='GIT_EDITOR, core.editor, and stuff'
 
 . ./test-lib.sh
 
-OLD_TERM="$TERM"
-
 for i in GIT_EDITOR core_editor EDITOR VISUAL vi
 do
 	cat >e-$i.sh <<-EOF
@@ -116,6 +114,4 @@ test_expect_success 'core.editor with a space' '
 
 '
 
-TERM="$OLD_TERM"
-
 test_done
-- 
1.5.5.rc2.20.g03f57.dirty

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2008-04-06 17:04 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-06 17:08 [PATCH] test suite: remove useless TERM cruft in "t7005-editor.sh" Christian Couder

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).