From: "Shawn O. Pearce" <spearce@spearce.org>
To: Pascal Obry <pascal@obry.net>
Cc: Junio C Hamano <gitster@pobox.com>,
Pascal Obry <pascal.obry@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] Add interactive option in rebase command completion list.
Date: Sun, 6 Apr 2008 15:09:27 -0400 [thread overview]
Message-ID: <20080406190927.GH10274@spearce.org> (raw)
In-Reply-To: <47F91A77.5080207@obry.net>
Pascal Obry <pascal@obry.net> wrote:
> Junio C Hamano a écrit :
> >Pascal Obry <pascal.obry@gmail.com> writes:
> >
> >>- __gitcomp "--onto --merge --strategy"
> >>+ __gitcomp "--onto --merge --strategy --interactive"
> >
> >I personally do not think this is worth it where a single "-i" is enough.
>
> I like unambiguous name (I do prefer --interactive instead of -i). It is
> painful to enter so the bash completion come quite handy here. The patch
> is safe, simple and clean, I see no reason to not include it.
I agree with Pascal here, include the option.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
--
Shawn.
next prev parent reply other threads:[~2008-04-06 19:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-06 17:32 [PATCH] Add interactive option in rebase command completion list Pascal Obry
2008-04-06 18:19 ` Junio C Hamano
2008-04-06 18:33 ` Elijah Newren
2008-04-06 18:46 ` Pascal Obry
2008-04-06 19:09 ` Shawn O. Pearce [this message]
2008-04-06 20:08 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080406190927.GH10274@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pascal.obry@gmail.com \
--cc=pascal@obry.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).