From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Shawn O. Pearce" Subject: Re: [PATCH] Add interactive option in rebase command completion list. Date: Sun, 6 Apr 2008 16:08:07 -0400 Message-ID: <20080406200807.GL10274@spearce.org> References: <1207503144-3008-1-git-send-email-pascal@obry.net> <7vprt2sv60.fsf@gitster.siamese.dyndns.org> <47F91A77.5080207@obry.net> <20080406190927.GH10274@spearce.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Junio C Hamano , Pascal Obry , git@vger.kernel.org To: Pascal Obry X-From: git-owner@vger.kernel.org Sun Apr 06 22:08:56 2008 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1JibAe-0004EV-1p for gcvg-git-2@gmane.org; Sun, 06 Apr 2008 22:08:56 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752733AbYDFUIM convert rfc822-to-quoted-printable (ORCPT ); Sun, 6 Apr 2008 16:08:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752723AbYDFUIM (ORCPT ); Sun, 6 Apr 2008 16:08:12 -0400 Received: from corvette.plexpod.net ([64.38.20.226]:49943 "EHLO corvette.plexpod.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752497AbYDFUIM convert rfc822-to-8bit (ORCPT ); Sun, 6 Apr 2008 16:08:12 -0400 Received: from cpe-74-70-48-173.nycap.res.rr.com ([74.70.48.173] helo=asimov.home.spearce.org) by corvette.plexpod.net with esmtpa (Exim 4.68) (envelope-from ) id 1Jib9k-0006pt-JW; Sun, 06 Apr 2008 16:08:00 -0400 Received: by asimov.home.spearce.org (Postfix, from userid 1000) id 6CED620FBAE; Sun, 6 Apr 2008 16:08:07 -0400 (EDT) Content-Disposition: inline In-Reply-To: <20080406190927.GH10274@spearce.org> User-Agent: Mutt/1.5.11 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - corvette.plexpod.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - spearce.org Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: "Shawn O. Pearce" wrote: > Pascal Obry wrote: > > Junio C Hamano a =C3=A9crit : > > >Pascal Obry writes: > > > > > >>- __gitcomp "--onto --merge --strategy" > > >>+ __gitcomp "--onto --merge --strategy --interactive" > > > > > >I personally do not think this is worth it where a single "-i" is = enough. > >=20 > > I like unambiguous name (I do prefer --interactive instead of -i). = It is=20 > > painful to enter so the bash completion come quite handy here. The = patch=20 > > is safe, simple and clean, I see no reason to not include it. >=20 > I agree with Pascal here, include the option. >=20 > Signed-off-by: Shawn O. Pearce Gaaaah. I didn't mean SBO. I mean Acked-by! Stupid fingers. --=20 Shawn.