git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jörg Sommer" <joerg@alea.gnuu.de>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: git-merge adds test to a message -- bug?
Date: Wed, 9 Apr 2008 12:40:48 +0200	[thread overview]
Message-ID: <20080409104048.GA1782@alea.gnuu.de> (raw)
In-Reply-To: <alpine.LSU.1.00.0803252102140.10660@wbgn129.biozentrum.uni-wuerzburg.de>

[-- Attachment #1: Type: text/plain, Size: 1900 bytes --]

Hallo Johannes,

Johannes Schindelin schrieb am Tue 25. Mar, 21:04 (+0100):
> On Tue, 25 Mar 2008, Jörg Sommer wrote:
> > Junio C Hamano schrieb am Mon 24. Mar, 09:45 (-0700):
> > > Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> > > > On Sun, 23 Mar 2008, Junio C Hamano wrote:
> > > >
> > > >> I unfortunately do not recall why _prepend_, and not _replace_, had 
> > > >> to be the right behaviour.
> > > >
> > > > http://article.gmane.org/gmane.comp.version-control.git/31896/match=git+merge+make+usable
> > > 
> > > So it was "my suspicion that people who would want to pass -m would 
> > > want it to behave this way".
> > > 
> > > I do not care deeply either way myself, as I never have found use for 
> > > -m to the merge command, but I think it could have been argued either 
> > > way.
> > 
> > I would like to argue for the replace way. :) Take git rebase -p as an 
> > example. If a merge is included in the rebase, it's redone with git 
> > merge -m. Because git rebase works with detached heads you get merge 
> > messages like this: [...]
> 
> That only means that the original author of rebase -p was a lazy bastard 
> and did not use the proper way to call git-merge, namely
> 
> 	git <msg> HEAD <the-other-branch>

It this really a proper way to call git merge? The manpage says:

    The second syntax (<msg> HEAD <remote>) is supported for historical
    reasons. Do not use it from the command line or in new scripts. It is
    the same as git merge -m <msg> <remote>.

And how would you pass the option for the strategy to this form? Git
rebase calls git merge with -s.

Bye, Jörg.
-- 
But in the case of "git revert", it should be an ancestor (or the user
is just insane, in which case it doesn't matter - insane people can do
insane things)
Linus Torvalds <alpine.LFD.1.00.0801041031590.2811@woody.linux-foundation.org>

[-- Attachment #2: Digital signature http://en.wikipedia.org/wiki/OpenPGP --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

      reply	other threads:[~2008-04-09 10:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-23 23:13 git-merge adds test to a message -- bug? Jörg Sommer
2008-03-24  5:17 ` Junio C Hamano
2008-03-24 11:08   ` Johannes Schindelin
2008-03-24 16:45     ` Junio C Hamano
2008-03-25  0:12       ` Jörg Sommer
2008-03-25 20:04         ` Johannes Schindelin
2008-04-09 10:40           ` Jörg Sommer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080409104048.GA1782@alea.gnuu.de \
    --to=joerg@alea.gnuu.de \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).