git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michele Ballabio <barra_cuda@katamail.com>
To: git@vger.kernel.org
Cc: Jan Engelhardt <jengelh@computergmbh.de>
Subject: [PATCH] revision.c: make --date-order overriddable
Date: Thu, 10 Apr 2008 22:06:52 +0200	[thread overview]
Message-ID: <200804102206.52464.barra_cuda@katamail.com> (raw)
In-Reply-To: <alpine.LNX.1.10.0804101342090.8765@fbirervta.pbzchgretzou.qr>

Jan Engelhardt noticed that while --topo-order can be overridden by a
subsequent --date-order, the reverse was not possible. That's because
setup_revisions() failed to set revs->lifo properly.

Signed-off-by: Michele Ballabio <barra_cuda@katamail.com>
---
On Thursday 10 April 2008, Jan Engelhardt wrote:
> git-rev-list --topo-order (the default) can be overriden by specifying 
> --date-order, but --date-order cannot be overriden by passing in 
> --topo-order again. Having it work would be really nice because it 
> allows extra programs to default to --date-order in some way.

This should do.

 revision.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/revision.c b/revision.c
index 196fedc..ffbed3f 100644
--- a/revision.c
+++ b/revision.c
@@ -1083,6 +1083,7 @@ int setup_revisions(int argc, const char **argv, struct rev_info *revs, const ch
 				continue;
 			}
 			if (!strcmp(arg, "--topo-order")) {
+				revs->lifo = 1;
 				revs->topo_order = 1;
 				continue;
 			}
-- 
1.5.5

      reply	other threads:[~2008-04-10 20:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-10 11:43 rev-list date-order not overridable Jan Engelhardt
2008-04-10 20:06 ` Michele Ballabio [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200804102206.52464.barra_cuda@katamail.com \
    --to=barra_cuda@katamail.com \
    --cc=git@vger.kernel.org \
    --cc=jengelh@computergmbh.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).