From: Heikki Orsila <shdl@zakalwe.fi>
To: Junio C Hamano <gitster@pobox.com>
Cc: Heikki Orsila <heikki.orsila@iki.fi>, git@vger.kernel.org
Subject: Re: [PATCH] Make core.sharedRepository more generic (version 2)
Date: Tue, 15 Apr 2008 04:22:49 +0300 [thread overview]
Message-ID: <20080415012249.GJ31039@zakalwe.fi> (raw)
In-Reply-To: <20080415004310.GI31039@zakalwe.fi>
On Tue, Apr 15, 2008 at 03:43:10AM +0300, Heikki Orsila wrote:
> On Mon, Apr 14, 2008 at 05:08:03PM -0700, Junio C Hamano wrote:
> > > + * of git. Note, we use octal numbers.
> > > */
> > > - sprintf(buf, "%d", shared_repository);
> > > + sprintf(buf, "0%o", shared_repository);
> >
> > Unconditionally doing this makes the resulting repository unusable by git
> > 1.5.5 and older, even when the user wanted to use the bog standard "git
> > init --shared". You can limit the extent of damage if you continue
> > writing PERM_GROUP and PERM_EVERYBODY out as 1 and 2, and use the new
> > octal notation only when the user used the settings allowed only with new
> > git.
>
> I submitted a new patch that should address all the points.
Submitted another version that really fixes the o+w case. Forgot
the 0664 mask there. Now it's 0666.
--
Heikki Orsila
heikki.orsila@iki.fi
http://www.iki.fi/shd
prev parent reply other threads:[~2008-04-15 1:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-12 19:57 [PATCH] Make core.sharedRepository more generic (version 2) Heikki Orsila
2008-04-15 0:08 ` Junio C Hamano
2008-04-15 0:43 ` Heikki Orsila
2008-04-15 1:22 ` Heikki Orsila [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080415012249.GJ31039@zakalwe.fi \
--to=shdl@zakalwe.fi \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=heikki.orsila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).