git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alex Riesen <raa.lkml@gmail.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Paul Mundt <lethal@linux-sh.org>,
	linux-sh@vger.kernel.org, Git Mailing List <git@vger.kernel.org>,
	Junio C Hamano <gitster@pobox.com>
Subject: Re: [GIT PULL] sh updates for 2.6.25
Date: Wed, 16 Apr 2008 20:54:49 +0200	[thread overview]
Message-ID: <20080416185449.GA27015@steel.home> (raw)
In-Reply-To: <alpine.LFD.1.00.0804151222350.2879@woody.linux-foundation.org>

Linus Torvalds, Tue, Apr 15, 2008 21:56:50 +0200:
> 
> 
> On Wed, 16 Apr 2008, Paul Mundt wrote:
> > 
> > It was a combination of mbox munging and git-am, I checked with git log
> > and thought things were ok, but I wasn't aware that it stripped out empty
> > lines. cat-file shows that it was just the 2 patches from Andrew that had
> > this particular problem. I had stripped out the subject and thought the
> > first line would be used for the merge summary, but it looks like git-am
> > simply wrote out an empty line and inserted one after that before the
> > rest of the summary.
> 
> Ahh, looks like a git-am buglet then. It will indeed turn an empty subject 
> line into an empty first line.
> 
> We should run "git stripspace" on the whole thing, so maybe a patch 
> something like the appended will help.
> 
> NOTE! Totally untested! Beware the patch!
> 

t4014-format-patch.sh broke. It probably has to be updated

  reply	other threads:[~2008-04-16 18:55 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20080415172333.GA29489@linux-sh.org>
2008-04-15 18:01 ` [GIT PULL] sh updates for 2.6.25 Linus Torvalds
2008-04-15 18:18   ` Linus Torvalds
2008-04-15 18:30   ` Paul Mundt
2008-04-15 19:56     ` Linus Torvalds
2008-04-16 18:54       ` Alex Riesen [this message]
2008-04-16 20:02       ` Junio C Hamano
2008-04-16 20:17         ` Linus Torvalds
2008-04-15 18:41   ` Junio C Hamano
2008-04-15 18:43   ` Jakub Narebski
2008-04-16  0:37     ` Miklos Vajna
2008-04-16  1:06       ` [PATCH] format-patch: Make sure the subject is always a one-liner Miklos Vajna
2008-04-16  3:25       ` [GIT PULL] sh updates for 2.6.25 Junio C Hamano
2008-04-16  8:44         ` Miklos Vajna
2008-04-16 19:58           ` Re* " Junio C Hamano
2008-04-16 20:22             ` Jakub Narebski
2008-04-17 21:38             ` Miklos Vajna
2008-04-27 19:04   ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080416185449.GA27015@steel.home \
    --to=raa.lkml@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=lethal@linux-sh.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).