git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Shawn O. Pearce" <spearce@spearce.org>
To: Dan McGee <dpmcgee@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] completion: allow 'git remote' subcommand completion
Date: Sun, 20 Apr 2008 15:22:59 -0400	[thread overview]
Message-ID: <20080420192259.GI29771@spearce.org> (raw)
In-Reply-To: <1208712525-1747-2-git-send-email-dpmcgee@gmail.com>

Dan McGee <dpmcgee@gmail.com> wrote:
> After typing 'git prune ', the subcommand options were not shown. Fix it.

That's not really what this change does.  It fixes the subcommands
for 'git remote ', which were broken without this __gitcomp call
in this location.

Acked-by: Shawn O. Pearce <spearce@spearce.org>

but I'd like to see a more accurate commit message for this fix.
 
> Signed-off-by: Dan McGee <dpmcgee@gmail.com>
> ---
>  contrib/completion/git-completion.bash |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 3f78630..6012047 100755
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -1052,6 +1052,7 @@ _git_remote ()
>  	local subcommands="add rm show prune update"
>  	local subcommand="$(__git_find_subcommand "$subcommands")"
>  	if [ -z "$subcommand" ]; then
> +		__gitcomp "$subcommands"
>  		return
>  	fi
>  
> -- 
> 1.5.5
> 

-- 
Shawn.

  reply	other threads:[~2008-04-20 19:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-20 17:28 [PATCH] completion: remove use of dashed git commands Dan McGee
2008-04-20 17:28 ` [PATCH] completion: allow 'git remote' subcommand completion Dan McGee
2008-04-20 19:22   ` Shawn O. Pearce [this message]
2008-04-20 19:34     ` Dan McGee
2008-04-20 17:43 ` [PATCH] completion: remove use of dashed git commands Johannes Schindelin
2008-04-20 17:49   ` Dan McGee
2008-04-20 17:54     ` Johannes Schindelin
2008-04-20 17:58       ` Dan McGee
2008-04-20 18:53       ` Matthieu Moy
2008-04-20 17:51   ` Junio C Hamano
2008-04-20 19:20 ` Shawn O. Pearce

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080420192259.GI29771@spearce.org \
    --to=spearce@spearce.org \
    --cc=dpmcgee@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).