git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] post-receive-email: fix accidental removal of a trailing space in signature line
@ 2008-04-21 13:44 Andy Parkins
  0 siblings, 0 replies; only message in thread
From: Andy Parkins @ 2008-04-21 13:44 UTC (permalink / raw)
  To: git

post-receive-email adds a signature to the end of emails in
generate_email_footer().  The signature was separated from the main email
body using the standard string "-- ". (see rfc3676)

In revision a6080a0a44d5, Junio's "war on whitespace" removed the trailing
whitespace from "-- ", leaving it as "--", which is not a correct
signature separator.

This patch restores the missing space, but does it in a way that will
not set off the trailing whitespace alarms.

Signed-off-by: Andy Parkins <andyparkins@gmail.com>
---
 contrib/hooks/post-receive-email |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email
index 62a740c..4136895 100644
--- a/contrib/hooks/post-receive-email
+++ b/contrib/hooks/post-receive-email
@@ -202,11 +202,12 @@ generate_email_header()
 
 generate_email_footer()
 {
+	SPACE=" "
 	cat <<-EOF
 
 
 	hooks/post-receive
-	--
+	--${SPACE}
 	$projectdesc
 	EOF
 }
-- 
1.5.5.29.g7134

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2008-04-21 13:46 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-21 13:44 [PATCH] post-receive-email: fix accidental removal of a trailing space in signature line Andy Parkins

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).