From: Andrew Morton <akpm@linux-foundation.org>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: warning: too many files, skipping inexact rename detection
Date: Sat, 26 Apr 2008 07:06:56 -0700 [thread overview]
Message-ID: <20080426070656.e7a01d91.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080426135737.GA382@sigill.intra.peff.net>
On Sat, 26 Apr 2008 09:57:37 -0400 Jeff King <peff@peff.net> wrote:
> On Sat, Apr 26, 2008 at 06:32:09AM -0700, Andrew Morton wrote:
>
> > I get the above message all the time when pulling all the git trees.
> >
> > I'm frightened!
>
> Rename detection is O(n^2), so when it looks like it will take a really
> long time, we skip it. This has been happening for a while, but 1.5.5
> only recently started telling the user (based on some people wondering
> why renames weren't found during their enormous merges).
>
> The default rename limit is 100, but you can bump it via the
> diff.renamelimit config option.
<wonders how to set that>
> A few tests that I did imply that
> 200-400 is reasonable for logging, and 800-1000 for a merge:
>
> http://article.gmane.org/gmane.comp.version-control.git/73519
>
> Are you running into actual problems with rename detection, or is the
> message just too scary and confusing?
No observed problems, just scared!
I don't use rename detection anyway - I use git to extract plain old diffs
only.
Perhaps the default should be bumped up a bit based on your measurements,
dunno.
next prev parent reply other threads:[~2008-04-26 14:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-26 13:32 warning: too many files, skipping inexact rename detection Andrew Morton
2008-04-26 13:57 ` Jeff King
2008-04-26 14:06 ` Andrew Morton [this message]
2008-04-26 14:52 ` Jeff King
2008-04-30 17:21 ` [PATCH 0/3] rename limit improvements Jeff King
2008-04-30 17:23 ` [PATCH 1/3] add merge.renamelimit config option Jeff King
2008-04-30 18:18 ` Jeff King
2008-05-03 20:15 ` Junio C Hamano
2008-05-04 19:31 ` Jeff King
2008-04-30 17:24 ` [PATCH 2/3] bump rename limit defaults Jeff King
2008-04-30 17:25 ` [PATCH 3/3] diff: make "too many files" rename warning optional Jeff King
2008-05-03 17:34 ` Ramsay Jones
2008-05-04 19:23 ` Jeff King
2008-05-04 23:28 ` Paul Mackerras
2008-05-05 13:59 ` Jeff King
2008-05-05 17:02 ` Jeff King
2008-05-05 19:52 ` Junio C Hamano
2008-05-12 11:15 ` Paul Mackerras
2008-05-06 22:33 ` Ramsay Jones
2008-05-06 22:29 ` Ramsay Jones
2008-05-04 0:10 ` Junio C Hamano
2008-05-04 19:20 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080426070656.e7a01d91.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).