* RFC822 From: fields
@ 2008-04-25 23:51 Stephen R. van den Berg
2008-04-26 0:01 ` Junio C Hamano
2008-04-26 8:49 ` Florian Weimer
0 siblings, 2 replies; 4+ messages in thread
From: Stephen R. van den Berg @ 2008-04-25 23:51 UTC (permalink / raw)
To: git
I noticed that the From: field generated by git-format-patch does not
conform to RFC822 format when the realname contains a dot (like mine).
Do we want to fix that in git-format-patch (only), or do we even want to
fix that in the stored commit author and committer fields?
--
Sincerely, srb@cuci.nl
Stephen R. van den Berg.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: RFC822 From: fields
2008-04-25 23:51 RFC822 From: fields Stephen R. van den Berg
@ 2008-04-26 0:01 ` Junio C Hamano
2008-04-26 8:49 ` Florian Weimer
1 sibling, 0 replies; 4+ messages in thread
From: Junio C Hamano @ 2008-04-26 0:01 UTC (permalink / raw)
To: Stephen R. van den Berg; +Cc: git
"Stephen R. van den Berg" <srb@cuci.nl> writes:
> I noticed that the From: field generated by git-format-patch does not
> conform to RFC822 format when the realname contains a dot (like mine).
> Do we want to fix that in git-format-patch (only), or do we even want to
> fix that in the stored commit author and committer fields?
I'd suspect that the answer should be "Neither", and rather inside
send-email.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: RFC822 From: fields
2008-04-25 23:51 RFC822 From: fields Stephen R. van den Berg
2008-04-26 0:01 ` Junio C Hamano
@ 2008-04-26 8:49 ` Florian Weimer
2008-04-26 11:45 ` Stephen R. van den Berg
1 sibling, 1 reply; 4+ messages in thread
From: Florian Weimer @ 2008-04-26 8:49 UTC (permalink / raw)
To: git
* Stephen R. van den Berg:
> I noticed that the From: field generated by git-format-patch does not
> conform to RFC822 format when the realname contains a dot (like mine).
> Do we want to fix that in git-format-patch (only), or do we even want to
> fix that in the stored commit author and committer fields?
This was fixed in RFC 2822, and the fix has already been deployed widely
(even before the advent of RFC 2822). I don't think there's any need to
change GIT.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: RFC822 From: fields
2008-04-26 8:49 ` Florian Weimer
@ 2008-04-26 11:45 ` Stephen R. van den Berg
0 siblings, 0 replies; 4+ messages in thread
From: Stephen R. van den Berg @ 2008-04-26 11:45 UTC (permalink / raw)
To: git
Florian Weimer wrote:
>* Stephen R. van den Berg:
>> I noticed that the From: field generated by git-format-patch does not
>> conform to RFC822 format when the realname contains a dot (like mine).
>This was fixed in RFC 2822, and the fix has already been deployed widely
>(even before the advent of RFC 2822). I don't think there's any need to
>change GIT.
True indeed. Ironically, the vger.kernel.org mailserver adheres to
RFC822 and ignores RFC2822 at the moment, which means that generating patches
from git, for the git mailinglist doesn't work without intervention.
I already contacted the vger-mailserver admin about this.
--
Sincerely, srb@cuci.nl
Stephen R. van den Berg.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-04-26 11:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-25 23:51 RFC822 From: fields Stephen R. van den Berg
2008-04-26 0:01 ` Junio C Hamano
2008-04-26 8:49 ` Florian Weimer
2008-04-26 11:45 ` Stephen R. van den Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).