Git development
 help / color / mirror / Atom feed
From: Brian Gernhardt <benji@silverinsanity.com>
To: git@vger.kernel.org
Subject: [PATCH 1/2] rebase -i: Use : in expr command instead of match.
Date: Sun, 27 Apr 2008 11:10:44 -0400	[thread overview]
Message-ID: <20080427151043.GA57955@Hermes.local> (raw)

`expr match $str $pattern` failed on OS X, and we already use
`expr $str : $pattern` in several other commands.

Signed-off-by: Brian Gernhardt <benji@silverinsanity.com>
---

 git-rebase--interactive.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh
index 303b754..2a01182 100755
--- a/git-rebase--interactive.sh
+++ b/git-rebase--interactive.sh
@@ -192,7 +192,7 @@ peek_next_command () {
 }
 
 mark_to_ref () {
-	if expr match "$1" "^:[0-9][0-9]*$" >/dev/null
+	if expr "$1" : "^:[0-9][0-9]*$" >/dev/null
 	then
 		echo "$mark_prefix$(printf %d ${1#:})"
 	else
-- 
1.5.5.1.174.g8f57349

                 reply	other threads:[~2008-04-27 15:11 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080427151043.GA57955@Hermes.local \
    --to=benji@silverinsanity.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox