From: Alex Riesen <raa.lkml@gmail.com>
To: Paul Mackerras <paulus@samba.org>
Cc: git@vger.kernel.org, Junio C Hamano <junkio@cox.net>
Subject: Re: [RESEND] [PATCH] Fix tree mode of the file list for files containing curly brackets
Date: Sun, 27 Apr 2008 18:51:56 +0200 [thread overview]
Message-ID: <20080427165156.GA3828@steel.home> (raw)
In-Reply-To: <18452.26961.14738.430774@cargo.ozlabs.ibm.com>
Paul Mackerras, Sun, Apr 27, 2008 13:53:53 +0200:
> Alex Riesen writes:
>
> > As far as I could understand the online documentation the [lindex ...]
> > thing expects an array, which a string produced by git-ls-tree is not.
> > So [split ...] it first, to get a real Tcl string-array.
>
> Unfortunately that will do the wrong thing if the filename contains a
> tab character. I think the right thing is to split the line textually
> at the tab, then treat the first part as a list (which will be OK
> since it consists of words without special characters, separated by
> spaces), and the second part as the filename. That is what I was
> trying to do anyway, but I forgot to strip off the part after the tab,
> which is why lindex got unhappy with it. Here's the patch I'm about
> to commit.
>
FWIW, it does the right thing for me:
$ git init
Initialized empty Git repository in .git/
$ >a
$ git add .
$ gci -m.
Created initial commit 86ee2fa: .
0 files changed, 0 insertions(+), 0 deletions(-)
create mode 100644 a
$ git mv a ' { b } '
$ gci -m.
Created commit 2a90dc5: .
1 files changed, 0 insertions(+), 0 deletions(-)
rename a => { b } (100%)
$ gitk
$ happy
The program 'happy' is currently not installed. You can install it by typing:
sudo apt-get install happy
bash: happy: command not found
prev parent reply other threads:[~2008-04-27 16:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-14 21:49 Fix tree mode of the file list for files containing curly brackets Alex Riesen
2008-03-14 21:58 ` [PATCH] " Alex Riesen
2008-04-27 10:57 ` [RESEND] " Alex Riesen
2008-04-27 11:53 ` Paul Mackerras
2008-04-27 16:51 ` Alex Riesen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080427165156.GA3828@steel.home \
--to=raa.lkml@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).