From: Jeff King <peff@peff.net>
To: Brian Gernhardt <benji@silverinsanity.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>, git@vger.kernel.org
Subject: Re: [PATCH 2/2] Fix t3404 assumption that `wc -l` does not use whitespace.
Date: Mon, 28 Apr 2008 05:41:19 -0400 [thread overview]
Message-ID: <20080428094119.GA20499@sigill.intra.peff.net> (raw)
In-Reply-To: <B287EA35-6C5D-4A5A-BEF1-C55A70D913ED@silverinsanity.com>
On Sun, Apr 27, 2008 at 11:32:24AM -0400, Brian Gernhardt wrote:
> Eh, not everyone's perfect. I would have used `rev` instead of `tac` and
> still been wrong for Solaris. But it seems that the `wc -l` whitespace
> issue seems to hit nearly everyone at some point, so I thought it would be
> a good candidate for CodingStyle.
>
> Personally, I'd love to have the time to review all the patches to catch
> these issues while still on the list instead of waiting until they hit
> next and I tried to compile it. But I don't always notice, have time, or
> care myself.
BTW, how did you discover this bug? Through normal use, or was there a
failing test?
If a failing test, then I wonder if we could get a few people to set up
automated tests on alternate platforms. IIRC, Junio makes sure that
master always passes test on his Linux box and KO (Debian and Redhat, I
think?). Other platforms could "git pull && make test" daily. I could
probably do Solaris (once I get the tests to complete pass at all!) and
FreeBSD 6.
-Peff
next prev parent reply other threads:[~2008-04-28 9:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-27 15:16 [PATCH 2/2] Fix t3404 assumption that `wc -l` does not use whitespace Brian Gernhardt
2008-04-27 15:22 ` Johannes Schindelin
2008-04-27 15:32 ` Brian Gernhardt
2008-04-28 9:41 ` Jeff King [this message]
2008-04-28 9:56 ` Mike Ralphson
2008-05-13 9:11 ` Jeff King
2008-05-13 18:10 ` Mike Ralphson
2008-05-15 10:16 ` Mike Ralphson
2008-05-15 11:20 ` Jeff King
2008-05-15 11:23 ` Jeff King
2008-05-15 17:18 ` Junio C Hamano
2008-05-16 14:22 ` Mike Ralphson
2008-04-28 12:40 ` Brian Gernhardt
2008-04-27 17:31 ` Junio C Hamano
2008-04-28 10:13 ` Johannes Schindelin
2008-04-28 11:40 ` Jörg Sommer
2008-04-28 13:42 ` Johannes Schindelin
2008-04-28 16:30 ` Jörg Sommer
2008-04-28 18:07 ` Johannes Schindelin
2008-04-28 16:19 ` Junio C Hamano
2008-04-28 18:01 ` Johannes Schindelin
2008-04-28 21:24 ` Junio C Hamano
2008-04-28 21:30 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080428094119.GA20499@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=benji@silverinsanity.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).