From: Miklos Vajna <vmiklos@frugalware.org>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] git-daemon: fix for rotating logs
Date: Mon, 28 Apr 2008 20:21:14 +0200 [thread overview]
Message-ID: <20080428182114.GF26880@genesis.frugalware.org> (raw)
In-Reply-To: <alpine.DEB.1.00.0804281908290.19187@eeepc-johanness>
[-- Attachment #1: Type: text/plain, Size: 597 bytes --]
On Mon, Apr 28, 2008 at 07:08:50PM +0100, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> > > With rotating logs, there is a problem when the syslog is opened only
> > > once (in the beginning). So open the log everytime we write
> > > something, and close it directly after writing.
> >
> > Gaah, this is ugly.
> >
> > Is this something all the daemons need to deal with?
>
> I have no idea, but it seems to fix a real issue.
logrotate supports sending a signal (typically SIGHUP) to the process
after it rotated the log. Couldn't we just re-open the log on SIGHUP?
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2008-04-28 18:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-28 14:24 [PATCH] git-daemon: fix for rotating logs Johannes Schindelin
2008-04-28 16:29 ` Junio C Hamano
2008-04-28 18:08 ` Johannes Schindelin
2008-04-28 18:21 ` Miklos Vajna [this message]
2008-04-28 18:29 ` Mike Hommey
2008-04-28 18:37 ` Johannes Schindelin
2008-04-28 19:00 ` Miklos Vajna
2008-04-28 19:24 ` Johannes Schindelin
2008-04-28 19:28 ` Stephen R. van den Berg
2008-04-28 19:53 ` Johannes Schindelin
2008-04-28 20:43 ` Stephen R. van den Berg
2008-04-28 20:53 ` Johannes Schindelin
2008-04-28 21:00 ` Stephen R. van den Berg
2008-04-28 21:09 ` Johannes Schindelin
2008-04-28 21:13 ` Stephen R. van den Berg
2008-04-28 21:23 ` Johannes Schindelin
2008-04-28 23:16 ` Stephen R. van den Berg
2008-04-29 6:17 ` Andreas Ericsson
2008-04-29 10:54 ` Johannes Schindelin
2008-04-29 11:00 ` Andreas Ericsson
2008-04-29 15:16 ` Johannes Schindelin
2008-04-29 17:58 ` Stephen R. van den Berg
2008-05-11 18:03 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080428182114.GF26880@genesis.frugalware.org \
--to=vmiklos@frugalware.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).