From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Couder Subject: Re: [PATCH] git-bisect.sh: don't accidentally override existing branch "bisect" Date: Wed, 30 Apr 2008 23:30:18 +0200 Message-ID: <200804302330.18354.chriscool@tuxfamily.org> References: <20080430164613.28314.qmail@b31db398e1accc.315fe32.mid.smarden.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: git@vger.kernel.org, Junio C Hamano To: Gerrit Pape X-From: git-owner@vger.kernel.org Wed Apr 30 23:26:09 2008 connect(): Connection refused Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1JrJoV-0004x4-O6 for gcvg-git-2@gmane.org; Wed, 30 Apr 2008 23:26:08 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764919AbYD3VZT convert rfc822-to-quoted-printable (ORCPT ); Wed, 30 Apr 2008 17:25:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1764678AbYD3VZT (ORCPT ); Wed, 30 Apr 2008 17:25:19 -0400 Received: from smtp1-g19.free.fr ([212.27.42.27]:57451 "EHLO smtp1-g19.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762925AbYD3VZQ convert rfc822-to-8bit (ORCPT ); Wed, 30 Apr 2008 17:25:16 -0400 Received: from smtp1-g19.free.fr (localhost.localdomain [127.0.0.1]) by smtp1-g19.free.fr (Postfix) with ESMTP id 9DFCD1AB2DC; Wed, 30 Apr 2008 23:25:15 +0200 (CEST) Received: from bureau.boubyland (gre92-7-82-243-130-161.fbx.proxad.net [82.243.130.161]) by smtp1-g19.free.fr (Postfix) with ESMTP id 5AE6C1AB2F3; Wed, 30 Apr 2008 23:25:15 +0200 (CEST) User-Agent: KMail/1.9.9 In-Reply-To: <20080430164613.28314.qmail@b31db398e1accc.315fe32.mid.smarden.org> Content-Disposition: inline Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Le mercredi 30 avril 2008, Gerrit Pape a =E9crit : > If a branch named "bisect" or "new-bisect" already was created in the > repo by other means than git bisect, doing a git bisect used to overr= ide > the branch without a warning. Now if the branch "bisect" or > "new-bisect" already exists, and it was not created by git bisect its= elf, > git bisect start fails with an appropriate error message. Additional= ly, > if checking out a new bisect state fails due to a merge problem, git > bisect cleans up the temporary branch "new-bisect". > > The accidental override has been noticed by Andres Salomon, reported > through > http://bugs.debian.org/478647 > > Signed-off-by: Gerrit Pape > --- > Documentation/git-bisect.txt | 2 +- > git-bisect.sh | 20 ++++++++++++++------ > t/t6030-bisect-porcelain.sh | 18 ++++++++++++++++++ > 3 files changed, 33 insertions(+), 7 deletions(-) > > diff --git a/Documentation/git-bisect.txt b/Documentation/git-bisect.= txt > index 698ffde..1c7e38d 100644 > --- a/Documentation/git-bisect.txt > +++ b/Documentation/git-bisect.txt > @@ -85,7 +85,7 @@ Oh, and then after you want to reset to the origina= l > head, do a $ git bisect reset > ------------------------------------------------ > > -to get back to the master branch, instead of being in one of the > +to get back to the original branch, instead of being in one of the > bisection branches ("git bisect start" will do that for you too, > actually: it will reset the bisection state, and before it does that > it checks that you're not using some old bisection branch). > diff --git a/git-bisect.sh b/git-bisect.sh > index d8d9bfd..48d81d5 100755 > --- a/git-bisect.sh > +++ b/git-bisect.sh > @@ -69,14 +69,19 @@ bisect_start() { > head=3D$(GIT_DIR=3D"$GIT_DIR" git symbolic-ref -q HEAD) || > head=3D$(GIT_DIR=3D"$GIT_DIR" git rev-parse --verify HEAD) || > die "Bad HEAD - I need a HEAD" > + # > + # Check that we either already have BISECT_START, or that the > + # branches bisect, new-bisect don't exist, to not override them. > + # > + test -s "$GIT_DIR/BISECT_START" || > + if git show-ref bisect > /dev/null || > + git show-ref new-bisect > /dev/null; then > + die 'The branches "bisect" and "new-bisect" must not exist.' > + fi Minor nitpick: you may use: git show-ref -q {new-,}bisect instead of: git show-ref bisect > /dev/null || git show-ref new-bisect > /dev/null That would give something like: test -s "$GIT_DIR/BISECT_START" || git show-ref -q {new-,}bisect && die 'The branches "bisect" and "new-bisect" must not exist.' > start_head=3D'' > case "$head" in > refs/heads/bisect) > - if [ -s "$GIT_DIR/BISECT_START" ]; then > - branch=3D`cat "$GIT_DIR/BISECT_START"` > - else > - branch=3Dmaster > - fi > + branch=3D`cat "$GIT_DIR/BISECT_START"` > git checkout $branch || exit > ;; > refs/heads/*|$_x40) > @@ -329,7 +334,10 @@ bisect_next() { > > echo "Bisecting: $bisect_nr revisions left to test after this" > git branch -f new-bisect "$bisect_rev" > - git checkout -q new-bisect || exit > + git checkout -q new-bisect || { > + git branch -d new-bisect > + exit Here we "exit 0" if "git branch -d new-bisect" succeeds. That seems wrong. > + } > git branch -M new-bisect bisect > git show-branch "$bisect_rev" > } > diff --git a/t/t6030-bisect-porcelain.sh b/t/t6030-bisect-porcelain.s= h > index 5e3e544..05f1e15 100755 > --- a/t/t6030-bisect-porcelain.sh > +++ b/t/t6030-bisect-porcelain.sh > @@ -284,6 +284,24 @@ test_expect_success 'bisect starting with a deta= ched > HEAD' ' > > ' > > +test_expect_success 'bisect refuses to start if branch bisect exists= ' ' > + git bisect reset && > + git branch bisect && > + test_must_fail git bisect start && > + git branch -d bisect && > + git checkout -b bisect && > + test_must_fail git bisect start && > + git checkout master && > + git branch -d bisect > +' > + > +test_expect_success 'bisect refuses to start if branch new-bisect > exists' ' + git bisect reset && > + git branch new-bisect && > + test_must_fail git bisect start && > + git branch -d new-bisect > +' > + > # > # > test_done Otherwise the patch looks good. Thanks, Christian.