Re: [PATCH 3/3] commit: Show the committer ident when is different from the parent

[Jeff King <peff@peff.net>]

On Thu, May 01, 2008 at 12:02:51PM -0700, Junio C Hamano wrote:

> Once you have a good algorithm to see when to trigger the warning that the
> user might be using an unintended committer identity, I do not think you
> should refrain from issuing the warning when you see the offending
> committer ident and whose commit you are building on top of should not
> affect it.  Otherwise, the user will get the warning once (or not even get

I think I must not be writing very clearly, because that is basically
the same point I have been trying to make in this thread.  Santi's
original algorithm for warning about the wrong committer ident was to
check whether it matched the parent commit. But my point was that is a
bad algorithm, because it has way too many false positives (i.e., you
will end up showing the committer _all the time_ in many workflows).
So the followup was "check this other thing, and also look at whether it
matches the parent" to which my response was "why bother checking the
parent match then?"

I also think you could argue that we should just show the committer all
the time. But I don't think anyone has made that argument.

> I think the other patch about showing the author when you are committing
> other's changes is a good move, by the way.

I agree; it has a very straightforward and sensible algorithm for when
to show.

-Peff