git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Couder <chriscool@tuxfamily.org>
To: Gerrit Pape <pape@smarden.org>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH amend] git-bisect.sh: don't accidentally override existing branch "bisect"
Date: Sat, 3 May 2008 10:42:31 +0200	[thread overview]
Message-ID: <200805031042.32190.chriscool@tuxfamily.org> (raw)
In-Reply-To: <20080502085620.3361.qmail@17e811992e6d42.315fe32.mid.smarden.org>

Le vendredi 2 mai 2008, Gerrit Pape a écrit :

[...]
> @@ -328,8 +333,8 @@ bisect_next() {
>  	exit_if_skipped_commits "$bisect_rev"
>
>  	echo "Bisecting: $bisect_nr revisions left to test after this"
> -	git branch -f new-bisect "$bisect_rev"
> -	git checkout -q new-bisect || exit
> +	git branch -D new-bisect

Doesn't this output an error if the branch "new-bisect" does not exists ?

$ git branch -D new-bisect
error: branch 'new-bisect' not found.

> +	git checkout -q -b new-bisect "$bisect_rev" || exit
>  	git branch -M new-bisect bisect
>  	git show-branch "$bisect_rev"
>  }

Thanks,
Christian.

  reply	other threads:[~2008-05-03  8:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-30 16:46 [PATCH] git-bisect.sh: don't accidentally override existing branch "bisect" Gerrit Pape
2008-04-30 21:30 ` Christian Couder
2008-05-01 12:15   ` Richard Quirk
2008-05-01 12:27     ` Christian Couder
2008-05-02  8:56   ` [PATCH amend] " Gerrit Pape
2008-05-03  8:42     ` Christian Couder [this message]
2008-05-05  7:43       ` Gerrit Pape
2008-05-06  6:20         ` Christian Couder
2008-05-02  8:22 ` [PATCH] " Karl Hasselström
2008-05-02 17:38   ` Junio C Hamano
2008-05-03 12:48     ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200805031042.32190.chriscool@tuxfamily.org \
    --to=chriscool@tuxfamily.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=pape@smarden.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).