From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, git@vger.kernel.org
Subject: Re: [PATCH 3/3] diff: make "too many files" rename warning optional
Date: Sun, 4 May 2008 15:20:15 -0400 [thread overview]
Message-ID: <20080504192015.GA13029@sigill.intra.peff.net> (raw)
In-Reply-To: <7vy76rrkry.fsf@gitster.siamese.dyndns.org>
On Sat, May 03, 2008 at 05:10:57PM -0700, Junio C Hamano wrote:
> > This neglects the case where the user specifically does a diff asking
> > for renames, but we turn it off. Maybe when "-M" is specified on the
> > commandline to git-diff, we should set this option as well.
>
> That sounds sensible. Like this?
I would have ack'd this, except it seems that the message produces some
problems with gitk, which explicitly calls diff-tree with -C (see the
message elsewhere in this thread from Ramsay Jones).
-Peff
prev parent reply other threads:[~2008-05-04 19:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-26 13:32 warning: too many files, skipping inexact rename detection Andrew Morton
2008-04-26 13:57 ` Jeff King
2008-04-26 14:06 ` Andrew Morton
2008-04-26 14:52 ` Jeff King
2008-04-30 17:21 ` [PATCH 0/3] rename limit improvements Jeff King
2008-04-30 17:23 ` [PATCH 1/3] add merge.renamelimit config option Jeff King
2008-04-30 18:18 ` Jeff King
2008-05-03 20:15 ` Junio C Hamano
2008-05-04 19:31 ` Jeff King
2008-04-30 17:24 ` [PATCH 2/3] bump rename limit defaults Jeff King
2008-04-30 17:25 ` [PATCH 3/3] diff: make "too many files" rename warning optional Jeff King
2008-05-03 17:34 ` Ramsay Jones
2008-05-04 19:23 ` Jeff King
2008-05-04 23:28 ` Paul Mackerras
2008-05-05 13:59 ` Jeff King
2008-05-05 17:02 ` Jeff King
2008-05-05 19:52 ` Junio C Hamano
2008-05-12 11:15 ` Paul Mackerras
2008-05-06 22:33 ` Ramsay Jones
2008-05-06 22:29 ` Ramsay Jones
2008-05-04 0:10 ` Junio C Hamano
2008-05-04 19:20 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080504192015.GA13029@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=akpm@linux-foundation.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).