From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: git@vger.kernel.org
Subject: [PATCH] Make creation of pack/pack-*.keep obey the umask
Date: Wed, 7 May 2008 11:25:48 -0600 [thread overview]
Message-ID: <20080507172548.GI24525@obsidianresearch.com> (raw)
Prevents git clone from complaining on shared repositories
Initialized empty Git repository in /tmp/src/.git/
cpio: objects/pack/pack-601efa4cfe63e081c0591b463549aeba3f7c6164.keep: Cannot open: Permission denied
3376 blocks
Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
---
I'm uncertain if the keep files should be sticking around for so long,
commit b8077709 makes it sounds like they are shorted lived lock
files. In the case I have the keep file contains:
fetch-pack 20810 on bertha1
But, I don't see anything in fetch-pack to erase the keep file.. In
any event making the file the same permissions as everything else
can't hurt.
index-pack.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/index-pack.c b/index-pack.c
index 9c0c278..eb19e98 100644
--- a/index-pack.c
+++ b/index-pack.c
@@ -707,7 +707,7 @@ static void final(const char *final_pack_name, const char *curr_pack_name,
get_object_directory(), sha1_to_hex(sha1));
keep_name = name;
}
- keep_fd = open(keep_name, O_RDWR|O_CREAT|O_EXCL, 0600);
+ keep_fd = open(keep_name, O_RDWR|O_CREAT|O_EXCL, 0666);
if (keep_fd < 0) {
if (errno != EEXIST)
die("cannot write keep file");
--
1.5.4.2
next reply other threads:[~2008-05-07 17:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-07 17:25 Jason Gunthorpe [this message]
2008-05-22 2:02 ` [PATCH] Make creation of pack/pack-*.keep obey the umask Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080507172548.GI24525@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).