From: Jeff King <peff@peff.net>
To: James Sadler <freshtonic@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: git filter-branch --subdirectory-filter
Date: Fri, 9 May 2008 04:00:39 -0400 [thread overview]
Message-ID: <20080509080039.GA15393@sigill.intra.peff.net> (raw)
In-Reply-To: <e5e204700805090038k373bbabcyfb10d8c93ec5b3a7@mail.gmail.com>
On Fri, May 09, 2008 at 05:38:12PM +1000, James Sadler wrote:
> I originally tried --subdirectory-filter by itself to see if it would
> do the job, but it filtered more commits than I thought it should
> (some commits that touched the subdir were missing after filter-branch
> was run).
>
> I then began to question my understanding of the semantics of
> subdirectory-filter.
>
> Is it meant to:
> A) Only keep commits where ALL of the changes in the commit only touch
> content under $DIR?
> B) Only keep commits where SOME of the changes in the commit touch
> content under $DIR?
>
> I suspected that it was behaving as A.
My understanding is that it should behave as B. E.g.:
git init
mkdir subdir1 subdir2
echo content 1 >subdir1/file
echo content 2 >subdir2/file
git add .
git commit -m initial
echo changes 1 >>subdir1/file
git commit -a -m 'only one'
echo more changes 1 >>subdir1/file
echo more changes 2 >>subdir2/file
git commit -a -m 'both'
git filter-branch --subdirectory-filter subdir1
git log --name-status --pretty=oneline
should show something like:
b119e21829b6039aa8fe938fb0304a9a7436b84d both
M file
db2ad8e702f36a1df99dd529aa594e756010b191 only one
M file
dacb4c2536e61c18079bcc73ea81fa0fb139c097 initial
A file
IOW, all commits touch subdir1/file, which becomes just 'file'.
It could be a bug in git-filter-branch. What version of git are you
using?
-Peff
next prev parent reply other threads:[~2008-05-09 8:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-09 1:01 git filter-branch --subdirectory-filter James Sadler
2008-05-09 1:33 ` Jeff King
2008-05-09 7:38 ` James Sadler
2008-05-09 7:57 ` Johannes Sixt
2008-05-09 8:00 ` Jeff King [this message]
2008-05-10 3:31 ` James Sadler
2008-05-10 5:53 ` Jeff King
2008-05-10 7:10 ` James Sadler
2008-05-10 11:38 ` James Sadler
2008-05-10 11:44 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080509080039.GA15393@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=freshtonic@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).