From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robin Rosenberg Subject: Re: [JGIT PATCH 0/m] Implementation of a file tree iteration using ignore rules. Date: Sat, 10 May 2008 22:45:08 +0200 Message-ID: <200805102245.08295.robin.rosenberg.lists@dewire.com> References: <1210424440-13886-1-git-send-email-florianskarten@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: git@vger.kernel.org To: Florian Koeberle X-From: git-owner@vger.kernel.org Sat May 10 22:46:58 2008 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1Juvy5-0006n9-Vj for gcvg-git-2@gmane.org; Sat, 10 May 2008 22:46:58 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755562AbYEJUqE convert rfc822-to-quoted-printable (ORCPT ); Sat, 10 May 2008 16:46:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754032AbYEJUqE (ORCPT ); Sat, 10 May 2008 16:46:04 -0400 Received: from [83.140.172.130] ([83.140.172.130]:12868 "EHLO dewire.com" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1755498AbYEJUqC convert rfc822-to-8bit (ORCPT ); Sat, 10 May 2008 16:46:02 -0400 Received: from localhost (localhost [127.0.0.1]) by dewire.com (Postfix) with ESMTP id B7B7C1434CBC; Sat, 10 May 2008 22:45:59 +0200 (CEST) X-Virus-Scanned: by amavisd-new at dewire.com Received: from dewire.com ([127.0.0.1]) by localhost (torino.dewire.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZHmoYVLJVkXp; Sat, 10 May 2008 22:45:58 +0200 (CEST) Received: from [10.9.0.4] (unknown [10.9.0.4]) by dewire.com (Postfix) with ESMTP id 7833C1434CBB; Sat, 10 May 2008 22:45:58 +0200 (CEST) User-Agent: KMail/1.9.9 In-Reply-To: <1210424440-13886-1-git-send-email-florianskarten@web.de> Content-Disposition: inline Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: l=F6rdagen den 10 maj 2008 15.00.18 skrev Florian Koeberle: > Hi >=20 Welcome to the project Florian! > here are the patches. >=20 > The implementation does a lot of performance optimizations: All good, but it would be nice to have some of these comments in the ja= vadocs too. I can sign Shawns comments and add a few on my own, not trying to be too pick= y and requiring you to think of everyhing I don't. We always play rough with newcomers = :) See the rest of my replies. -- robin