From mboxrd@z Thu Jan  1 00:00:00 1970
From: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
Subject: Re: [JGIT PATCH 21/22] Added test class FileIterableFactoryForAddCommandTest.
Date: Sat, 10 May 2008 22:53:59 +0200
Message-ID: <200805102253.59158.robin.rosenberg.lists@dewire.com>
References: <1210424440-13886-1-git-send-email-florianskarten@web.de> <1210424440-13886-22-git-send-email-florianskarten@web.de>
Mime-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Cc: git@vger.kernel.org
To: Florian Koeberle <florianskarten@web.de>
X-From: git-owner@vger.kernel.org Sat May 10 22:56:56 2008
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git-2@gmane.org
Received: from vger.kernel.org ([209.132.176.167])
	by lo.gmane.org with esmtp (Exim 4.50)
	id 1Juw6X-0001Wm-GI
	for gcvg-git-2@gmane.org; Sat, 10 May 2008 22:55:41 +0200
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755931AbYEJUyv (ORCPT <rfc822;gcvg-git-2@m.gmane.org>);
	Sat, 10 May 2008 16:54:51 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755925AbYEJUyv
	(ORCPT <rfc822;git-outgoing>); Sat, 10 May 2008 16:54:51 -0400
Received: from [83.140.172.130] ([83.140.172.130]:12949 "EHLO dewire.com"
	rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP
	id S1755899AbYEJUyu (ORCPT <rfc822;git@vger.kernel.org>);
	Sat, 10 May 2008 16:54:50 -0400
Received: from localhost (localhost [127.0.0.1])
	by dewire.com (Postfix) with ESMTP id 846221434CC0;
	Sat, 10 May 2008 22:54:49 +0200 (CEST)
X-Virus-Scanned: by amavisd-new at dewire.com
Received: from dewire.com ([127.0.0.1])
	by localhost (torino.dewire.com [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id wamQAykJbgpf; Sat, 10 May 2008 22:54:49 +0200 (CEST)
Received: from [10.9.0.4] (unknown [10.9.0.4])
	by dewire.com (Postfix) with ESMTP id 29DD51434CBF;
	Sat, 10 May 2008 22:54:49 +0200 (CEST)
User-Agent: KMail/1.9.9
In-Reply-To: <1210424440-13886-22-git-send-email-florianskarten@web.de>
Content-Disposition: inline
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/81704>

> +public class FileIterableFactoryForAddCommandTest extends TestCase {

We have RepositoryTestcase that we use for unit tests that require a test repository.
Consider using it. If not usable, why not? Maybe we can fix that. It includes logic
to clean on "next" and handle some messy problems of cleaning up and avoiding
problems when re-running failed tests under Windows (read "locked files and directories");

-- robin