git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: "J.H." <warthog19@eaglescrag.net>
Cc: git@vger.kernel.org, Petr Baudis <pasky@suse.cz>
Subject: Re: [RFC/PATCH] gitweb: Paginate project list
Date: Mon, 12 May 2008 01:51:19 +0200	[thread overview]
Message-ID: <200805120151.20741.jnareb@gmail.com> (raw)
In-Reply-To: <1210485210.11526.145.camel@localhost.localdomain>

On Sun, 11 May 2008, J.H. wrote:
> 
> On Sun, 2008-05-11 at 00:32 +0200, Jakub Narebski wrote:
>> On Sun, 10 May 2008, J.H. <warthog19@eaglescrag.net> wrote:
>>
>> BTW. why do you think that kernel.org would be better to have project
>> list pagination turned off?
> 
> If we have caching on I'd rather leave it as a single page, much easier
> to search on and with firefox /<project or name> then <ctrl>+g a couple
> of times is really fast to find what I need.  Also means less to cache
> (good for us) and faster access for most.  I'm going to guess leaving it
> as a single page, unless it gets *very* unwieldy, will be how we leave
> it.

First, you can cache individual pages of projects list output with
small overhead if number of projects per page is large enough.  Second,
see my earlier patch adding project search capability to gitweb
(it is server-side search, though).  Searching needs caching data, not
output, while pagination only can be done with both.


As to single-page projects list being being unwieldy...  You should
take into account how large the page is (having page size in megabytes
isn't too good), how much time it takes to download (and not only
generate), and how much time it takes for web browser to render it.

How many repositories is "too many", that I'm not sure about...

>>> It might also be advantageous to generate the entire list and stash that
>>> somewhere, (session on the host side?) and run the pagination out of
>>> that.
>> 
>> First, when using $projectslist file with new (second patch in series,
>> "gitweb: Allow project description in project_index file" most of data
>> (well, all except age) would be filled by parsing single file.
>> 
>> Second, the idea is to cache results of filled in @$projlist e.g. using
>> Storable, i.e. cache Perl data and not final HTML output.
> 
> I approve of that plan, caching all the html is kinda expensive *hides
> the 20G of gitweb cache he has*

Caching output (HTML) has the advantage of being simple, and avoiding
time to generate page.  Caching data has the advantage of taking less
disk space due to being able to reuse the same data for different pages.
 
-- 
Jakub Narebski
Poland

  reply	other threads:[~2008-05-11 23:52 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-01 10:20 [RFC/PATCH] gitweb: Simplify git_project_list_body Jakub Narebski
2008-05-02 10:30 ` [RFC/PATCH] gitweb: Allow project description in project_index file Jakub Narebski
2008-05-02 13:04   ` Miklos Vajna
2008-05-03  9:03     ` Jakub Narebski
2008-05-04  2:03       ` Miklos Vajna
2008-05-09 13:23       ` [RFC/PATCH] gitweb: Project search Jakub Narebski
2008-05-10  9:28         ` [RFC/PATCH] gitweb: Paginate project list Jakub Narebski
2008-05-10 18:28           ` J.H.
2008-05-10 22:32             ` Jakub Narebski
2008-05-11  5:53               ` J.H.
2008-05-11 23:51                 ` Jakub Narebski [this message]
     [not found]                 ` <8c5c35580805102356p7e5532aah319af921f9b19392@mail.gmail.com>
2008-05-12  7:03                   ` Jakub Narebski
2008-05-12 15:43                     ` Lars Hjemli
2008-05-13  6:55                       ` Jakub Narebski
     [not found]                         ` <8c5c35580805130939m1a1ef8e0yd72402f3c79190ea@mail.gmail.com>
2008-05-13 16:46                           ` Lars Hjemli
2008-05-13 17:04                           ` Jakub Narebski
2008-05-13 19:11                             ` Kristian Høgsberg
2008-05-13 19:30                             ` Lars Hjemli
2008-05-13 23:28                               ` Jakub Narebski
2008-05-14  7:59                                 ` Jakub Narebski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200805120151.20741.jnareb@gmail.com \
    --to=jnareb@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=pasky@suse.cz \
    --cc=warthog19@eaglescrag.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).