From: Alex Riesen <raa.lkml@gmail.com>
To: Git Mailing List <git@vger.kernel.org>
Cc: "Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Dirk Süsserott" <newsletter@dirk.my1.cc>,
"Junio C Hamano" <gitster@pobox.com>
Subject: [PATCH] Add --ignore-errors to git-add to allow it to skip files with read errors
Date: Mon, 12 May 2008 19:58:29 +0200 [thread overview]
Message-ID: <20080512175829.GE3128@steel.home> (raw)
In-Reply-To: <20080512175810.GD3128@steel.home>
Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
---
Documentation/git-add.txt | 7 ++++++-
builtin-add.c | 11 +++++++++--
2 files changed, 15 insertions(+), 3 deletions(-)
diff --git a/Documentation/git-add.txt b/Documentation/git-add.txt
index e0e730b..bb4abe2 100644
--- a/Documentation/git-add.txt
+++ b/Documentation/git-add.txt
@@ -9,7 +9,7 @@ SYNOPSIS
--------
[verse]
'git-add' [-n] [-v] [-f] [--interactive | -i] [--patch | -p] [-u] [--refresh]
- [--] <filepattern>...
+ [--ignore-errors] [--] <filepattern>...
DESCRIPTION
-----------
@@ -83,6 +83,11 @@ OPTIONS
Don't add the file(s), but only refresh their stat()
information in the index.
+\--ignore-errors::
+ If some files could not be added because of errors indexing
+ them, do not abort the operation, but continue adding the
+ others. The command shall still exit with non-zero status.
+
\--::
This option can be used to separate command-line options from
the list of files, (useful when filenames might be mistaken
diff --git a/builtin-add.c b/builtin-add.c
index 7862808..522519e 100644
--- a/builtin-add.c
+++ b/builtin-add.c
@@ -191,6 +191,7 @@ static const char ignore_error[] =
"The following paths are ignored by one of your .gitignore files:\n";
static int verbose = 0, show_only = 0, ignored_too = 0, refresh_only = 0;
+static int ignore_add_errors;
static struct option builtin_add_options[] = {
OPT__DRY_RUN(&show_only),
@@ -201,6 +202,7 @@ static struct option builtin_add_options[] = {
OPT_BOOLEAN('f', NULL, &ignored_too, "allow adding otherwise ignored files"),
OPT_BOOLEAN('u', NULL, &take_worktree_changes, "update tracked files"),
OPT_BOOLEAN( 0 , "refresh", &refresh_only, "don't add, only refresh the index"),
+ OPT_BOOLEAN( 0 , "ignore-errors", &ignore_add_errors, "just skip files which cannot be added because of errors"),
OPT_END(),
};
@@ -231,6 +233,8 @@ int cmd_add(int argc, const char **argv, const char *prefix)
if (verbose)
flags |= ADD_FILES_VERBOSE;
+ if (ignore_add_errors)
+ flags |= ADD_FILES_IGNORE_ERRORS;
exit_status = add_files_to_cache(prefix, pathspec, flags);
goto finish;
@@ -274,8 +278,11 @@ int cmd_add(int argc, const char **argv, const char *prefix)
}
for (i = 0; i < dir.nr; i++)
- if (add_file_to_cache(dir.entries[i]->name, verbose))
- die("adding files failed");
+ if (add_file_to_cache(dir.entries[i]->name, verbose)) {
+ if (!ignore_add_errors)
+ die("adding files failed");
+ exit_status = 1;
+ }
finish:
if (active_cache_changed) {
--
1.5.5.1.184.g5bee
next prev parent reply other threads:[~2008-05-12 17:59 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-01 13:46 How to "git add ." when some files are not accessible (permission denied)? Dirk Süsserott
2008-03-02 1:19 ` Jeff King
2008-03-03 19:17 ` Dirk Süsserott
2008-03-03 20:06 ` Junio C Hamano
2008-03-03 20:32 ` Dirk Süsserott
2008-03-02 15:41 ` Alex Riesen
2008-03-02 15:42 ` [PATCH] Make the exit code of add_file_to_index actually useful Alex Riesen
2008-03-02 15:43 ` [PATCH] Extend interface of add_files_to_cache to allow ignore indexing errors Alex Riesen
2008-03-02 15:44 ` [PATCH] Add --ignore-errors to git-add to allow it to skip files with read errors Alex Riesen
2008-03-02 15:44 ` [PATCH] Add a test for git-add --ignore-errors Alex Riesen
2008-03-02 15:57 ` [PATCH] Make the exit code of add_file_to_index actually useful Johannes Schindelin
2008-03-02 16:59 ` Junio C Hamano
2008-03-02 21:42 ` Alex Riesen
2008-03-02 22:04 ` Joachim B Haga
2008-03-03 6:57 ` Alex Riesen
2008-05-12 17:56 ` Alex Riesen
2008-05-12 17:57 ` Alex Riesen
2008-05-12 17:58 ` [PATCH] Extend interface of add_files_to_cache to allow ignore indexing errors Alex Riesen
2008-05-12 17:58 ` Alex Riesen [this message]
2008-05-12 17:58 ` [PATCH] Add a test for git-add --ignore-errors Alex Riesen
2008-05-12 17:59 ` [PATCH] Add a config option to ignore errors for git-add Alex Riesen
2008-05-13 3:48 ` [PATCH] Add a test for git-add --ignore-errors Junio C Hamano
2008-05-13 6:04 ` Alex Riesen
2008-05-13 6:05 ` Junio C Hamano
2008-05-13 22:28 ` Alex Riesen
2008-05-12 18:42 ` [PATCH] Make the exit code of add_file_to_index actually useful Junio C Hamano
2008-05-12 20:54 ` Alex Riesen
2008-05-12 22:19 ` Junio C Hamano
2008-05-12 22:48 ` Alex Riesen
2008-05-12 23:32 ` Junio C Hamano
2008-05-13 6:00 ` Alex Riesen
2008-03-03 18:01 ` Daniel Barkalow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080512175829.GE3128@steel.home \
--to=raa.lkml@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=newsletter@dirk.my1.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).