From: Jeff King <peff@peff.net>
To: Daniel Barkalow <barkalow@iabervon.org>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: git clone broken in next
Date: Thu, 15 May 2008 00:50:26 -0400 [thread overview]
Message-ID: <20080515045026.GA26161@sigill.intra.peff.net> (raw)
In-Reply-To: <20080515044402.GA3517@sigill.intra.peff.net>
On Thu, May 15, 2008 at 12:44:02AM -0400, Jeff King wrote:
> Hmm, builtin-clone does seem to be completely broken. It looks like
> unpack_trees is not doing its job for some reason, but I haven't looked
> further. But it surprised me that we aren't testing anything as simple
> as "clone works". The test below currently fails (though I am getting
> other test failures which are presumably related).
>
> ---
> diff --git a/t/t5601-clone.sh b/t/t5601-clone.sh
> index dc9d63d..593d1a3 100755
> --- a/t/t5601-clone.sh
> +++ b/t/t5601-clone.sh
> @@ -23,4 +23,11 @@ test_expect_success 'clone with excess parameters' '
>
> '
>
> +test_expect_success 'clone checks out files' '
> +
> + git clone src dst &&
> + test -f dst/file
> +
> +'
> +
> test_done
Just to be sure, I bisected this test, and sure enough, the problem
commit is 8434c2f1 (build in clone). Daniel?
-Peff
next prev parent reply other threads:[~2008-05-15 4:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-15 3:54 git clone broken in next Kevin Ballard
2008-05-15 4:44 ` Jeff King
2008-05-15 4:50 ` Jeff King [this message]
2008-05-15 9:48 ` [PATCH] builtin-clone: fix initial checkout Johannes Schindelin
2008-05-15 10:54 ` Jeff King
2008-05-15 15:17 ` Daniel Barkalow
2008-05-15 19:53 ` Kevin Ballard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080515045026.GA26161@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).