Re: To page or not to page

[Jeff King <peff@peff.net>]

On Fri, May 16, 2008 at 12:42:38AM -0400, Jeff King wrote:

> So the logic in setup_git_env seems bogus, but should basically never be
> invoked because we do generally call setup_git_directory_gently before
> then. Either it should probably call setup_git_directory_gently (though
> I am afraid of what awful side effects that could have), or it should
> just barf, and people should do setup_git_directory beforehand (and I'm
> sure that will break something too).

Hrm. So there are lots of programs that actually _do_ end up needing
this lazy load of the git_dir, but it's just that we have
setup_git_directory'd ourselves into the top of the work tree by then.

So it would be nice if we could move that earlier so that the wrapper
could do useful things like look at the proper config. But I think that
opens a whole can of worms with running setup_git_directory twice, IIRC.

-Peff