git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Seth Falcon <seth@userprimary.net>
To: Toby Allsopp <Toby.Allsopp@navman.co.nz>
Cc: Ping Yin <pkufranky@gmail.com>, Git Mailing List <git@vger.kernel.org>
Subject: Re: git and peer review
Date: Sat, 17 May 2008 14:30:39 -0700	[thread overview]
Message-ID: <20080517213039.GR396@ziti.local> (raw)
In-Reply-To: <87k5i9u8f1.fsf@nav-akl-pcn-343.mitacad.com>

* On 2008-05-05 at 08:21 +1200 Toby Allsopp wrote:
> I do something similar using git filter-branch --msg-filter.  I have a
> little shell script call git-add-checked (our convention is to have a
> "checked: " line in the commit message):

That's a useful script, thanks for posting it.  I'd like to make it a
bit safer to use -- the first time I tried it I didn't give any branch
limiting args and it started filtering a lot of history :-P

What I would like is a way for the script to determine the appropriate
tracking branch.  So that the usage would look like:

   git mark-reviewed someone@userprimary.net

and it would figure out whether it should do trunk.. or release-1.3..,
etc.  Can anyone point me in the right direction?


-- 
Seth Falcon | http://userprimary.net/user/

  parent reply	other threads:[~2008-05-17 21:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-03  1:02 git and peer review Ping Yin
2008-05-03 13:54 ` Thomas Adam
2008-05-03 14:03   ` Ping Yin
2008-05-03 14:22     ` Frodo Baggins
2008-05-03 14:27       ` Ping Yin
2008-05-04 20:21 ` Toby Allsopp
2008-05-05  0:52   ` Ping Yin
2008-05-05 13:48   ` Karl Hasselström
2008-05-17 21:30   ` Seth Falcon [this message]
2008-05-19  3:37     ` Shawn O. Pearce
2008-05-19 14:10       ` Seth Falcon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080517213039.GR396@ziti.local \
    --to=seth@userprimary.net \
    --cc=Toby.Allsopp@navman.co.nz \
    --cc=git@vger.kernel.org \
    --cc=pkufranky@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).