From: Alex Riesen <raa.lkml@gmail.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Junio C Hamano <junkio@cox.net>
Subject: Re: t3701 fails if core.filemode disabled
Date: Mon, 19 May 2008 22:23:42 +0200 [thread overview]
Message-ID: <20080519202342.GA9694@steel.home> (raw)
In-Reply-To: <20080518200121.GA5789@steel.home>
Alex Riesen, Sun, May 18, 2008 22:01:21 +0200:
> Jeff King, Sun, May 18, 2008 21:08:39 +0200:
> > I don't mind disabling these tests if they don't make sense on certain
> > platforms, but regarding your specific proposal:
> >
> > - can you confirm that the test doesn't make sense, and not that it is
> > simply broken on cygwin? Does changing your ~/.gitconfig's
> > core.filemode make a difference? It shouldn't, but that could be
> > a bug in test-lib. What happens if you run the test manually? Does
> > git-add just not prompt for the mode change?
>
> I setting core.filemode _inside_ the test breaks it in exactly the
> same way (on Linux, I'm at home). I'll retest tomorrow
It is "git init" which sets core.filemode false (of course!)
next prev parent reply other threads:[~2008-05-19 20:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-18 15:23 t3701 fails if core.filemode disabled Alex Riesen
2008-05-18 15:35 ` Johannes Schindelin
2008-05-18 17:04 ` Alex Riesen
2008-05-18 19:08 ` Jeff King
2008-05-18 20:01 ` Alex Riesen
2008-05-19 20:23 ` Alex Riesen [this message]
2008-05-19 20:55 ` Jeff King
2008-05-20 21:59 ` [PATCH] Fix t3701 " Alex Riesen
2008-05-21 14:36 ` Jeff King
2008-05-22 13:20 ` Alex Riesen
2008-05-22 17:49 ` Junio C Hamano
2008-05-22 17:55 ` Jeff King
2008-05-22 21:22 ` Alex Riesen
2008-05-19 0:17 ` t3701 fails " Mark Levedahl
2008-05-19 6:01 ` Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080519202342.GA9694@steel.home \
--to=raa.lkml@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).