From: Heikki Orsila <shd@modeemi.fi>
To: Junio C Hamano <junio@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Add format.date config variable
Date: Thu, 22 May 2008 02:27:35 +0300 [thread overview]
Message-ID: <20080521232735.GB10527@jolt.modeemi.cs.tut.fi> (raw)
In-Reply-To: <7vtzgr347p.fsf@gitster.siamese.dyndns.org>
On Wed, May 21, 2008 at 11:24:42AM -0700, Junio C Hamano wrote:
> > Also, add missing "short" alternative to --date in rev-list-options.txt.
>
> Good change but is a separate issue. Please make it a [PATCH 1/2].
Will do that a separate patch.
> Lacking Sign-off.
OK. Thanks.
> The patch itself is good, especially that you made sure that format-patch
> output is not affected.
>
> As to the configuration variable name, I'd suggest "log.date" instead.
OK.
Will submit a patch later today.
--
Heikki Orsila
heikki.orsila@iki.fi
http://www.iki.fi/shd
prev parent reply other threads:[~2008-05-21 23:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-18 17:13 [PATCH] Add format.date config variable Heikki Orsila
2008-05-18 17:39 ` Teemu Likonen
2008-05-21 18:24 ` Junio C Hamano
2008-05-21 23:27 ` Heikki Orsila [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080521232735.GB10527@jolt.modeemi.cs.tut.fi \
--to=shd@modeemi.fi \
--cc=git@vger.kernel.org \
--cc=junio@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).