From: "Shawn O. Pearce" <spearce@spearce.org>
To: Twiinz <twiinz@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
git@vger.kernel.org
Subject: Re: Two minor tweaks on git-gui where textboxes weren't vertically centered with their labels and buttons
Date: Thu, 22 May 2008 08:55:59 -0400 [thread overview]
Message-ID: <20080522125559.GO29038@spearce.org> (raw)
In-Reply-To: <412a1d9a0805220545veb9af51y833aed2234d258b@mail.gmail.com>
Twiinz <twiinz@gmail.com> wrote:
> On Thu, May 22, 2008 at 7:11 PM, Shawn O. Pearce <spearce@spearce.org> wrote:
> > In this case it is a very trivial patch. Anyone who tries to do
> > the same thing is likely to come up with the same result, or one
> > that is close enough that it looks identical anyway.
> >
> > Still, it isn't in my main tree, because it is lacking a proper
> > Signed-off-by tag by the original author.
>
> Sorry for the late response,
>
> It's a very trivial patch, indeed.
>
> I'm still a bit confused with those Signed-off-by things. Anyway I
> sign hereby that:
> - I coded those few lines myself
> - I didn't steal them from anyone
> - I'm not going to sue anybody over its utilization
See "Sign your work" of git.git/Documentation/SubmittingPatches:
http://repo.or.cz/w/git.git?a=blob;f=Documentation/SubmittingPatches;h=0e155c936c25255706bc6d47651c2b336c628417;hb=377d9c409ffe0f0d994b929aeb94716139207b9d
I think most reasonable people would say your statement has roughly
the same intent and effect as the Developer's Certificate of
Origin 1.1.
> If there's more that need to be done to get this patch approved please
> point me to some online materials that detail the process.
>
> I hope that helps,
I'm going to edit your commit and add the signed off by line for you:
Signed-off-by: Twiinz <twiinz@gmail.com>
Thanks.
--
Shawn.
next prev parent reply other threads:[~2008-05-22 12:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-18 5:18 Two minor tweaks on git-gui where textboxes weren't vertically centered with their labels and buttons Twiinz
2008-05-19 4:07 ` Shawn O. Pearce
2008-05-19 5:34 ` Twiinz
2008-05-19 10:28 ` Johannes Schindelin
2008-05-21 7:01 ` Junio C Hamano
2008-05-22 12:11 ` Shawn O. Pearce
2008-05-22 12:45 ` Twiinz
2008-05-22 12:55 ` Shawn O. Pearce [this message]
2008-05-22 13:09 ` Twiinz
2008-05-22 17:46 ` Junio C Hamano
2008-05-22 22:57 ` Shawn O. Pearce
2008-05-22 23:59 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080522125559.GO29038@spearce.org \
--to=spearce@spearce.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=twiinz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).