From: Clemens Buchacher <drizzd@aon.at>
To: git@vger.kernel.org
Subject: [PATCH] http-push: remove remote locks on exit signals
Date: Thu, 22 May 2008 21:55:46 +0200 [thread overview]
Message-ID: <20080522195546.GA29911@localhost> (raw)
If locks are not cleaned up the repository is inaccessible for 10 minutes.
Signed-off-by: Clemens Buchacher <drizzd@aon.at>
---
Hi,
To test this I created a large file, added it, commited, pushed, waited one
second and pressed Ctrl+C. If this method is acceptable for the regression
tests, or if you have a better idea, let me know. I will write up a script.
Regards,
Clemens
---
http-push.c | 20 ++++++++++++++++++++
1 files changed, 20 insertions(+), 0 deletions(-)
diff --git a/http-push.c b/http-push.c
index 5b23038..b1f5302 100644
--- a/http-push.c
+++ b/http-push.c
@@ -1349,6 +1349,24 @@ static int unlock_remote(struct remote_lock *lock)
return rc;
}
+static void remove_locks(void)
+{
+ struct remote_lock *lock = remote->locks;
+
+ fprintf(stderr, "Removing remote locks...\n");
+ while (lock) {
+ unlock_remote(lock);
+ lock = lock->next;
+ }
+}
+
+static void remove_locks_on_signal(int signo)
+{
+ remove_locks();
+ signal(SIGINT, SIG_DFL);
+ raise(signo);
+}
+
static void remote_ls(const char *path, int flags,
void (*userFunc)(struct remote_ls_ctx *ls),
void *userData);
@@ -2255,6 +2273,8 @@ int main(int argc, char **argv)
goto cleanup;
}
+ signal(SIGINT, remove_locks_on_signal);
+
/* Check whether the remote has server info files */
remote->can_update_info_refs = 0;
remote->has_info_refs = remote_exists("info/refs");
--
1.5.5.1.1.g95a6
next reply other threads:[~2008-05-22 19:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-22 19:55 Clemens Buchacher [this message]
2008-05-23 21:40 ` [PATCH] http-push: remove remote locks on exit signals Junio C Hamano
2008-05-23 22:17 ` Clemens Buchacher
2008-05-25 18:26 ` [PATCH] Reset the signal being handled Clemens Buchacher
2008-05-26 9:34 ` Johannes Schindelin
2008-05-26 19:35 ` [PATCH] lockfile: reset the correct signal Clemens Buchacher
2008-05-26 21:36 ` Johannes Schindelin
2008-05-27 7:49 ` Clemens Buchacher
2008-05-25 18:27 ` [PATCH] http-push: remove remote locks on exit signals Clemens Buchacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080522195546.GA29911@localhost \
--to=drizzd@aon.at \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).