git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Shawn O. Pearce" <spearce@spearce.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Twiinz <twiinz@gmail.com>,
	git@vger.kernel.org
Subject: Re: Two minor tweaks on git-gui where textboxes weren't vertically centered with their labels and buttons
Date: Thu, 22 May 2008 18:57:30 -0400	[thread overview]
Message-ID: <20080522225730.GQ29038@spearce.org> (raw)
In-Reply-To: <7v4p8qw7to.fsf@gitster.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> wrote:
> "Shawn O. Pearce" <spearce@spearce.org> writes:
> > In this case it is a very trivial patch.
> 
> Yeah, I realized that I should have added that after sending the message.
> I'd rather not to see a patch without S-o-b than with a S-o-b with a
> phoney name, though.

Like this one?

  commit 2b36b146fa892a0a326eb2e35a39c9daf58fbe5e
  Author: A Large Angry SCM <gitzilla@gmail.com>
  Date:   Sat May 10 16:52:51 2008 -0400

    git-repack: re-enable parsing of -n command line option
    
    In commit 5715d0b (Migrate git-repack.sh to use git-rev-parse --parseopt,
    2007-11-04), parsing of the '-n' command line option was accidentally lost
    when git-repack.sh was migrated to use git-rev-parse --parseopt. This adds
    it back.
    
    Signed-off-by: A Large Angry SCM <gitzilla@gmail.com>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>

;-)

Are we starting to make a submission policy that all contributions
need to have a non-phony looking name for the author line and
SBO?  We have not done so in the past, and we do not have the
infrastructure like The Eclipse Foundation has to require all
contributors to execute a (possibly enforceable) legal agreement
stating their contribution can be distributed under the GPLv2.

-- 
Shawn.

  reply	other threads:[~2008-05-22 22:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-18  5:18 Two minor tweaks on git-gui where textboxes weren't vertically centered with their labels and buttons Twiinz
2008-05-19  4:07 ` Shawn O. Pearce
2008-05-19  5:34   ` Twiinz
2008-05-19 10:28     ` Johannes Schindelin
2008-05-21  7:01       ` Junio C Hamano
2008-05-22 12:11         ` Shawn O. Pearce
2008-05-22 12:45           ` Twiinz
2008-05-22 12:55             ` Shawn O. Pearce
2008-05-22 13:09               ` Twiinz
2008-05-22 17:46           ` Junio C Hamano
2008-05-22 22:57             ` Shawn O. Pearce [this message]
2008-05-22 23:59               ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080522225730.GQ29038@spearce.org \
    --to=spearce@spearce.org \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=twiinz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).