From: Johan Herland <johan@herland.net>
To: Daniel Barkalow <barkalow@iabervon.org>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] Add a test for another combination of --reference
Date: Fri, 23 May 2008 00:34:33 +0200 [thread overview]
Message-ID: <200805230034.33567.johan@herland.net> (raw)
In-Reply-To: <alpine.LNX.1.00.0805221800090.19665@iabervon.org>
On Friday 23 May 2008, Daniel Barkalow wrote:
> From: Johan Herland <johan@herland.net>
>
> In this case, the reference repository has some useful loose objects,
> but not all useful objects, and we make sure that we can find the
> objects we fetch from the repository we're cloning in the new
> repository, instead of potentially being distracted by the reference
> repository.
>
> Doing the wrong thing in a builtin-clone implementation would lead to
> this looking for an object in the wrong place, not finding it (because
> it's only in the right place), and crashing.
>
> Signed-off-by: Johan Herland <johan@herland.net>
> Signed-off-by: Daniel Barkalow <barkalow@iabervon.org>
Thanks again.
...Johan
PS: I'm holding off on submitting my builtin-clone-packs-refs series until
1.5.6 is out. I think builtin-clone has seen enough action in this cycle. :)
--
Johan Herland, <johan@herland.net>
www.herland.net
next prev parent reply other threads:[~2008-05-22 22:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-22 22:03 [PATCH] Add a test for another combination of --reference Daniel Barkalow
2008-05-22 22:34 ` Johan Herland [this message]
2008-05-23 2:03 ` Daniel Barkalow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200805230034.33567.johan@herland.net \
--to=johan@herland.net \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox