From: Miklos Vajna <vmiklos@frugalware.org>
To: Daniel Barkalow <barkalow@iabervon.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/5] Move reset_index_file() to a new reset.c
Date: Sat, 24 May 2008 23:55:30 +0200 [thread overview]
Message-ID: <20080524215530.GA27724@genesis.frugalware.org> (raw)
In-Reply-To: <alpine.LNX.1.00.0805240016230.19665@iabervon.org>
[-- Attachment #1: Type: text/plain, Size: 824 bytes --]
On Sat, May 24, 2008 at 12:21:42AM -0400, Daniel Barkalow <barkalow@iabervon.org> wrote:
> You might as well use unpack_trees() directly here, instead of running a
> separate command. In fact, you might skip making a function here, and just
> call unpack_trees() where you'd use it. (And maybe have a function to
> initialize a struct unpack_tree_options to some common defaults to make it
> easy to see what's being done.)
Thanks for the suggestion, I did so; as a result now patch #1 and #3 are
no longer necessary.
(I haven't sent out a new series yet, but it's in
git://repo.or.cz/git/vmiklos.git builtin-merge.)
Maybe builtin-reset could use unpack_trees() directly as well? I don't
know if it's just a question of "nobody did it yet", or there is some
reason for not using unpack_trees() there.
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
prev parent reply other threads:[~2008-05-24 21:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-24 0:01 [WIP PATCH 0/5] Build in merge Miklos Vajna
2008-05-24 0:01 ` [PATCH 1/5] Move reset_index_file() to a new reset.c Miklos Vajna
2008-05-24 0:01 ` [PATCH 2/5] Move split_cmdline() to libgit Miklos Vajna
2008-05-24 0:01 ` [PATCH 3/5] Make verbosity configurable in reset_index_file() Miklos Vajna
2008-05-24 0:01 ` [PATCH 4/5] Move commit_list_count() to commit.c Miklos Vajna
2008-05-24 0:01 ` [PATCH 5/5] Build in merge Miklos Vajna
2008-05-27 14:08 ` [PATCH 3/5] Make verbosity configurable in reset_index_file() Kristian Høgsberg
2008-05-27 14:49 ` Miklos Vajna
2008-05-24 4:21 ` [PATCH 1/5] Move reset_index_file() to a new reset.c Daniel Barkalow
2008-05-24 21:55 ` Miklos Vajna [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080524215530.GA27724@genesis.frugalware.org \
--to=vmiklos@frugalware.org \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).