From: Teemu Likonen <tlikonen@iki.fi>
To: Junio C Hamano <gitster@pobox.com>
Cc: Adam Simpkins <adam@adamsimpkins.net>, git@vger.kernel.org
Subject: Re: [PATCH 0/1] graph API: always print 'M' for merge commits
Date: Sun, 25 May 2008 09:29:27 +0300 [thread overview]
Message-ID: <20080525062927.GA3174@mithlond.arda.local> (raw)
In-Reply-To: <7vabifkw9j.fsf@gitster.siamese.dyndns.org>
Junio C Hamano wrote (2008-05-24 18:28 -0700):
> Adam Simpkins <adam@adamsimpkins.net> writes:
>
> > Okay. Here's a simple patch to restore the behavior of always
> > printing 'M' for merge commits, even if less than 2 parents are
> > shown in the graph.
>
> I have to wonder if that is really necessary. A merge commit, unless
> you amend it, always starts with "Merge ...", and I think it is enough
> clue of what the particular commit did. Besides, I think letter "M"
> in the pictorial part of the graph simply looks rather ugly.
>
> I would even suggest not to use 'M' at all, whether its parents are
> interesting or not.
I don't have strong opinions on this, although I prefer different
symbols for these conceptually different commits - in the current graph
view. But if in the future someone implements an option like
log.unicodegraph=true which displays the graph with nice Unicode chars,
then I think M's wouldn't quite fit there visually anymore.
next prev parent reply other threads:[~2008-05-25 6:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-23 20:42 bug in "git log --graph" at the tail end? Junio C Hamano
2008-05-23 21:02 ` Reece Dunn
2008-05-24 1:05 ` Adam Simpkins
2008-05-24 1:39 ` Junio C Hamano
2008-05-24 2:24 ` [PATCH 0/2] fix "log --graph" issues with uninteresting parents Adam Simpkins
2008-05-24 2:24 ` [PATCH 1/2] graph API: fix graph mis-alignment after uninteresting commits Adam Simpkins
2008-05-24 2:24 ` [PATCH 2/2] graph API: don't print branch lines for uninteresting merge parents Adam Simpkins
2008-05-24 18:25 ` Teemu Likonen
2008-05-24 20:52 ` [PATCH 0/1] graph API: always print 'M' for merge commits Adam Simpkins
2008-05-24 20:52 ` [PATCH 1/1] " Adam Simpkins
2008-05-24 22:21 ` Adam Simpkins
2008-05-25 1:28 ` [PATCH 0/1] " Junio C Hamano
2008-05-25 6:29 ` Teemu Likonen [this message]
2008-05-25 6:49 ` Adam Simpkins
2008-05-24 22:21 ` [PATCH 2/2] graph API: don't print branch lines for uninteresting merge parents Adam Simpkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080525062927.GA3174@mithlond.arda.local \
--to=tlikonen@iki.fi \
--cc=adam@adamsimpkins.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).