From: Petr Baudis <pasky@suse.cz>
To: Lea Wiemann <lewiemann@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: perl/Git.pm: Writing a test suite
Date: Fri, 30 May 2008 12:03:06 +0200 [thread overview]
Message-ID: <20080530100306.GF18781@machine.or.cz> (raw)
In-Reply-To: <483FB034.3050507@gmail.com>
Hi,
On Fri, May 30, 2008 at 09:43:48AM +0200, Lea Wiemann wrote:
> Git.pm doesn't currently have a test suite, and I think it should get one.
>
> Since Git.pm makes calls to the git binary, it would seem sensible to me to
> create mock output for the external calls, like Grit (a Ruby API) does it,
> here: http://github.com/mojombo/grit/tree/master/test/fixtures (Having a
> complete test repository to test against like Ruby/Git (another API) at
> http://repo.or.cz/w/rubygit.git?a=tree;f=tests/files;hb=HEAD is probably
> too brittle and makes it hard to test edge cases.)
I think this is bad idea; you should test not just Git.pm
functionality, but equally importantly also its integration with
(current version of) Git. If Git's output/behaviour changes in some
subtle way, you want to see if it breaks Git.pm.
> I haven't done testing in perl before, so if someone wants to exchange
> ideas and/or help me get this set up, please post here or message me on IRC
> (lea_w/lea_1 on #git at Freenode).
There are two possible ways, either using the Git test suite
infrastructure, or the Perl test suite infrastructure. I'm ambivalent
about which one to choose, both have their advantages; I wonder what
others' opinion is. I would personally go with the Perl test suite in
this case but can't support it with much more than just a gut feeling.
--
Petr "Pasky" Baudis
Whatever you can do, or dream you can, begin it.
Boldness has genius, power, and magic in it. -- J. W. von Goethe
next prev parent reply other threads:[~2008-05-30 10:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-30 7:43 perl/Git.pm: Writing a test suite Lea Wiemann
2008-05-30 8:03 ` Rafael Garcia-Suarez
2008-05-30 10:03 ` Petr Baudis [this message]
2008-05-30 13:44 ` Lea Wiemann
2008-05-30 20:28 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080530100306.GF18781@machine.or.cz \
--to=pasky@suse.cz \
--cc=git@vger.kernel.org \
--cc=lewiemann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).