From: "Shawn O. Pearce" <spearce@spearce.org>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Michael Dressel <MichaelTiloDressel@t-online.de>, git@vger.kernel.org
Subject: Re: [PATCH] describe match pattern for soft tags too
Date: Tue, 3 Jun 2008 18:42:26 -0400 [thread overview]
Message-ID: <20080603224225.GN12896@spearce.org> (raw)
In-Reply-To: <alpine.DEB.1.00.0806032124040.13507@racer.site.net>
Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> On Tue, 3 Jun 2008, Michael Dressel wrote:
>
> > So far git describe --match <pattern> would apply the <pattern> only
> > to tag objects not to soft tags.
>
> And I thought that was what --tags was for.
Yes. However there is a bug in git-describe's implementation;
--match only tested on annotated tags. The test was buried inside
of the block that handles the annotated case. Michael's patch pulls
this test outside where it can apply to lightweight tags when --tags
is included on the command line.
--
Shawn.
next prev parent reply other threads:[~2008-06-03 22:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-03 17:59 [PATCH] describe match pattern for soft tags too Michael Dressel
2008-06-03 20:24 ` Johannes Schindelin
2008-06-03 22:42 ` Shawn O. Pearce [this message]
2008-06-03 22:48 ` Shawn O. Pearce
2008-06-04 6:04 ` Junio C Hamano
2008-06-04 19:06 ` Michael Dressel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080603224225.GN12896@spearce.org \
--to=spearce@spearce.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=MichaelTiloDressel@t-online.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).