From: "Shawn O. Pearce" <spearce@spearce.org>
To: Michael Dressel <MichaelTiloDressel@t-online.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] describe match pattern for soft tags too
Date: Tue, 3 Jun 2008 18:48:39 -0400 [thread overview]
Message-ID: <20080603224839.GO12896@spearce.org> (raw)
In-Reply-To: <alpine.LNX.1.10.0806031957360.3605@pollux>
Michael Dressel <MichaelTiloDressel@t-online.de> wrote:
>
> So far git describe --match <pattern> would apply the <pattern> only
> to tag objects not to soft tags. This change make describe apply
> the <pattern> to soft tags too.
Whoops.
Signed-off-by tag?
Assuming you supply Junio an SBO tag,
Acked-by: Shawn O. Pearce <spearce@spearce.org>
> ---
> builtin-describe.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/builtin-describe.c b/builtin-describe.c
> index df554b3..a1b8251 100644
> --- a/builtin-describe.c
> +++ b/builtin-describe.c
> @@ -82,10 +82,10 @@ static int get_name(const char *path, const unsigned
> char *sha1, int flag, void
> if (might_be_tag) {
> if (is_tag) {
> prio = 2;
> - if (pattern && fnmatch(pattern, path + 10, 0))
> - prio = 0;
> } else
> prio = 1;
> + if (pattern && fnmatch(pattern, path + 10, 0))
> + prio = 0;
> }
> else
> prio = 0;
--
Shawn.
next prev parent reply other threads:[~2008-06-03 22:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-03 17:59 [PATCH] describe match pattern for soft tags too Michael Dressel
2008-06-03 20:24 ` Johannes Schindelin
2008-06-03 22:42 ` Shawn O. Pearce
2008-06-03 22:48 ` Shawn O. Pearce [this message]
2008-06-04 6:04 ` Junio C Hamano
2008-06-04 19:06 ` Michael Dressel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080603224839.GO12896@spearce.org \
--to=spearce@spearce.org \
--cc=MichaelTiloDressel@t-online.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).