From: "Shawn O. Pearce" <spearce@spearce.org>
To: Michael Dressel <MichaelTiloDressel@t-online.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] describe: match pattern for lightweight tags too
Date: Wed, 4 Jun 2008 15:55:16 -0400 [thread overview]
Message-ID: <20080604195516.GT12896@spearce.org> (raw)
In-Reply-To: <alpine.LNX.1.10.0806042101080.3410@pollux>
Michael Dressel <MichaelTiloDressel@t-online.de> wrote:
>
> So far git describe --match <pattern> would apply the <pattern> only
> to tag objects not to lightweight tags. This change make describe apply
> the <pattern> to lightweight tags too.
>
> Signed-off-by: Michael Dressel <MichaelTiloDressel@t-online.de>
Acked-by: Shawn O. Pearce <spearce@spearce.org>
> diff --git a/builtin-describe.c b/builtin-describe.c
> index df554b3..3da99c1 100644
> --- a/builtin-describe.c
> +++ b/builtin-describe.c
> @@ -80,12 +80,13 @@ static int get_name(const char *path, const unsigned
> char *sha1, int flag, void
> * Otherwise only annotated tags are used.
> */
> if (might_be_tag) {
> - if (is_tag) {
> + if (is_tag)
> prio = 2;
> - if (pattern && fnmatch(pattern, path + 10, 0))
> - prio = 0;
> - } else
> + else
> prio = 1;
> +
> + if (pattern && fnmatch(pattern, path + 10, 0))
> + prio = 0;
> }
> else
> prio = 0;
--
Shawn.
next prev parent reply other threads:[~2008-06-04 19:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-04 19:06 [PATCH] describe: match pattern for lightweight tags too Michael Dressel
2008-06-04 19:55 ` Shawn O. Pearce [this message]
2008-06-04 20:09 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080604195516.GT12896@spearce.org \
--to=spearce@spearce.org \
--cc=MichaelTiloDressel@t-online.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox