git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Andrew Klossner <andrew@cesa.opbu.xerox.com>, git@vger.kernel.org
Subject: Re: git clone stable-2.6.25.y fails over HTTP
Date: Wed, 4 Jun 2008 22:08:55 -0700	[thread overview]
Message-ID: <20080605050855.GA22825@kroah.com> (raw)
In-Reply-To: <7vabi05xl1.fsf@gitster.siamese.dyndns.org>

On Wed, Jun 04, 2008 at 09:12:42PM -0700, Junio C Hamano wrote:
> Greg KH <greg@kroah.com> writes:
> 
> > On Wed, Jun 04, 2008 at 10:09:02AM -0700, Junio C Hamano wrote:
> >
> >> A quick fix is obviously to remove the extra prefix but it makes me wonder
> >> how these two "stable" repositories were prepared differently.  Could this
> >> be a regression in "git clone"?  Or perhaps you "clone -s"'s Linus's
> >> repository slightly differently between them?
> >
> > That's odd.
> >
> > Chris was the one that created the .24 tree and I created the .25 tree,
> > so we must have done so differently, sorry.
> 
> No need to be sorry.  Thanks for raising the issue up.
> 
> I think I have one possible explanation.  When "git clone" was rewritten
> in C some time ago, it started to dereference symlinks, and newer git
> would dereference /pub -> /home/ftp/pub when you do:
> 
> 	git clone -s --bare /pub/scm/linux/kernel/git/torvalds/linux-2.6/ linux-2.6.2x.y
> 
> while the scripted version used to keep /pub/scm path.
> 
> A bit further digging is necessary to make sure if we can fix this easily,
> but I suspect this is worth fixing.

I can duplicate what I did, and it did it again:
	on master.kernel.org:
	$ cd /pub/scm/linux/kernel/git/stable/
	$ git clone -s --bare ../torvalds/linux-2.6.git/ test
	$ cat test/objects/info/alternates
	/home/ftp/pub/scm/linux/kernel/git/torvalds/linux-2.6.git/objects

I'm guessing this is because /pub/ is a symlink:
	$ ls -l /pub
	lrwxrwxrwx 1 root root 13 Feb  4  2006 /pub -> /home/ftp/pub

	$ git --version
	git version 1.5.5.3

thanks,

greg k-h

  reply	other threads:[~2008-06-05  5:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200806041511.m54FBPL9006783@pogo.cesa.opbu.xerox.com>
2008-06-04 15:45 ` git clone stable-2.6.25.y fails over HTTP Greg KH
2008-06-04 17:09   ` Junio C Hamano
2008-06-04 18:00     ` Jakub Narebski
2008-06-04 18:02       ` Junio C Hamano
2008-06-05  4:03     ` Greg KH
2008-06-05  4:12       ` Junio C Hamano
2008-06-05  5:08         ` Greg KH [this message]
2008-06-05 20:53           ` Daniel Barkalow
2008-06-05 21:26             ` Junio C Hamano
2008-06-06 20:48               ` Greg KH
2008-06-06 21:00                 ` Junio C Hamano
2008-06-06 21:54                   ` Greg KH
2008-06-10 15:05 Andrew Klossner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080605050855.GA22825@kroah.com \
    --to=greg@kroah.com \
    --cc=andrew@cesa.opbu.xerox.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).