Re: [JGIT PATCH 00/12] Extensions in core needed by PackWriter

[Robin Rosenberg <robin.rosenberg@dewire.com>]

måndagen den 2 juni 2008 23.24.31 skrev Marek Zawirski:
> Hello,
> 
> Here is my first GSoC series - some work from the last week.
> It's actually not a PackWriter, but some changes in existing jgit core
> related to PackWriting. Some of these added methods/refactors are not yet
> used within this series, but are used in my dirty branch in PackWriter
> which is under-development, even somewhat usable.
> 
> Series start with formatting stuff, as some old files were not
> appropriatelly formatted.
> 
> This series is also available at my corechanges branch:
> http://repo.or.cz/w/egit/zawir.git?a=shortlog;h=refs/heads/corechanges
> It's based on Shawn's bsd branch, with new BSD-style license, but I can
> rebase if really needed.
No, that's fine. 
> 
> If you want to track some PackWriter (itself) development you may want to
> have a look at my dirty branch:
> http://repo.or.cz/w/egit/zawir.git?a=shortlog;h=refs/heads/dirty
> 
> That's all. Although Shawn already reviewed some old version of this patches,
> I'm still interested in your comments.

A well defined set of enhancements with only minor nitpicks (in separate mails)  I'm somewhat reluctant to reformatting patches though. Ideally we'd be using eclipse 3.4 and have it format changed parts automatically on save (or similar feature for other IDE's). I tried format on all classes leading to 118 files changed, but nothing major, just a lot of changes with no relevant to readability, except some cases which only made things worse.  That's a reason why I have not formatted code according to settings, although
the most common reason is probably sloppiness.

-- robin