From: Alex Riesen <raa.lkml@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [TOY PATCH] git wrapper: show similar command names for an unknown command
Date: Sat, 7 Jun 2008 09:27:21 +0200 [thread overview]
Message-ID: <20080607072721.GA3347@steel.home> (raw)
In-Reply-To: <alpine.DEB.1.00.0806050747000.21190@racer>
Johannes Schindelin, Thu, Jun 05, 2008 08:48:40 +0200:
> A typical output would now look like this:
>
> $ git reabse
> git: 'reabse' is not a git-command. See 'git --help'.
>
> Did you mean one of these?
> rebase
> merge-base
> rev-parse
> remote
> rerere
>
That's really cool :) And I find it useful (and already applied it to
my tree). For me, it works like a simple reminder about what I was
about to do. Helps when working on many things at the same time
(typical typo: mrge. And your patch shows it as the first hit).
BTW, you probably want to restrict the number of lines output.
For instance, "git ma" (am, printed correctly in the first line)
lists around 30 commands, which scrolls clear a 25 line terminal
and is a lot of output anyway. I tried it with at most 5 hints:
diff --git a/help.c b/help.c
index ac29225..765eed8 100644
--- a/help.c
+++ b/help.c
@@ -640,7 +640,7 @@ static int levenshtein_compare(const void *p1, const void *p2)
void help_unknown_cmd(const char *cmd)
{
- int i, header_shown = 0;
+ int i, header_shown = 0, listed = 0;
fprintf(stderr, "git: '%s' is not a git-command. See 'git --help'.\n", cmd);
@@ -667,6 +667,8 @@ void help_unknown_cmd(const char *cmd)
header_shown = 1;
}
fprintf(stderr, "\t%s\n", main_cmds.names[i]->name);
+ if (++listed >= 5)
+ break;
}
exit(1);
next prev parent reply other threads:[~2008-06-07 7:28 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-05 6:48 [TOY PATCH] git wrapper: show similar command names for an unknown command Johannes Schindelin
2008-06-05 8:19 ` [PATCH] Add subcommand "help" to the list of most commonly used subcommands Teemu Likonen
2008-06-05 10:32 ` Johannes Schindelin
2008-06-05 10:52 ` Teemu Likonen
2008-06-05 10:57 ` [PATCH v2 1/2] " Teemu Likonen
2008-06-05 10:57 ` [PATCH v2 2/2] More informative short description for git-help.txt Teemu Likonen
2008-06-05 12:58 ` [PATCH] Add subcommand "help" to the list of most commonly used subcommands Johannes Schindelin
2008-06-05 11:21 ` Sverre Rabbelier
2008-06-05 13:22 ` Teemu Likonen
2008-06-05 18:13 ` Junio C Hamano
2008-06-05 18:38 ` Pieter de Bie
2008-06-05 21:15 ` Teemu Likonen
2008-06-05 21:17 ` Junio C Hamano
2008-06-06 5:11 ` David Symonds
2008-06-05 18:42 ` Wincent Colaiuta
2008-06-05 19:15 ` Sverre Rabbelier
2008-06-05 20:59 ` [TOY PATCH] git wrapper: show similar command names for an unknown command Dirk Süsserott
2008-06-05 23:00 ` Johannes Schindelin
2008-06-06 12:15 ` Robin Rosenberg
2008-06-06 14:18 ` Wincent Colaiuta
2008-06-07 7:27 ` Alex Riesen [this message]
2008-06-07 15:04 ` Johannes Schindelin
2008-06-07 17:51 ` Alex Riesen
2008-06-07 18:08 ` Junio C Hamano
2008-06-08 15:07 ` Johannes Schindelin
2008-06-08 15:14 ` Dirk Süsserott
2008-06-08 17:53 ` Junio C Hamano
2008-06-08 23:26 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080607072721.GA3347@steel.home \
--to=raa.lkml@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).