Re: [PATCH] git-rebase -i: have an option for amending the commit message only.

[Pierre Habouzit <madcoder@debian.org>]

[-- Attachment #1: Type: text/plain, Size: 1274 bytes --]

On Wed, Jun 11, 2008 at 06:36:45PM +0000, Olivier Marin wrote:
> Hi,
> 
> I like the feature and I have just two comments:
> 
> Pierre Habouzit a écrit :
> >
> > +	comment|c)
> 
> Is "comment" the right name? I'm not sure, I just ask.

  Well, edit would have been better, but it's taken already. 'message'
has m as a shortcut, already taken by merge, so 'comment' felt like the
best I could come up with.

  To be fair, if someone has a better name, I'm all for it. I quite care
about the feature, edit needs me to run the --amend myself, whereas I
often just want to fix a typo in a commit log.

> > +		comment_for_reflog comment
> > +
> > +		mark_action_done
> > +		pick_one $sha1 ||
> > +			die_with_patch $sha1 "Could not apply $sha1... $rest"
> > +		output git commit --no-verify --amend -e -C HEAD
> 
> It does not work with an editor that opens in the current terminal
> like vi. Just remove "output" should fix the problem, I think.

  I'm surprised because I used it this way, but maybe it was on the
machine where my git editor is gvim and not vim …

-- 
·O·  Pierre Habouzit
··O                                                madcoder@debian.org
OOO                                                http://www.madism.org

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]