From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Lea Wiemann <lewiemann@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] t/.gitattributes: only ignore whitespace errors in test files
Date: Sat, 14 Jun 2008 02:48:57 -0400 [thread overview]
Message-ID: <20080614064857.GA8930@sigill.intra.peff.net> (raw)
In-Reply-To: <7vod65wt6k.fsf@gitster.siamese.dyndns.org>
On Fri, Jun 13, 2008 at 03:00:35AM -0700, Junio C Hamano wrote:
> Eventually we would want to make all of the t/*.sh not exempt from the
> whitespace rules. Some currently do have trailing whitespaces as part of
This turned out to be a fairly easy change, as most of the places had
been caught already.
Four part patch series follows. The only one potentially not
maint-worthy is 3/4, because it actually changes git's output slightly.
1/4: fix whitespace violations in test scripts
2/4: mask necessary whitespace policy violations in test scripts
3/4: avoid trailing whitespace in zero-change diffstat lines
4/4: enable whitespace checking of test scripts
-Peff
next prev parent reply other threads:[~2008-06-14 6:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-12 22:35 [PATCH] t/.gitattributes: only ignore whitespace errors in test files Lea Wiemann
2008-06-13 6:06 ` Jeff King
2008-06-13 7:49 ` [PATCH v2] " Lea Wiemann
2008-06-13 10:00 ` [PATCH] " Junio C Hamano
2008-06-14 6:48 ` Jeff King [this message]
2008-06-14 6:51 ` [PATCH 1/4] fix whitespace violations in test scripts Jeff King
2008-06-14 7:01 ` Jeff King
2008-06-14 7:20 ` Junio C Hamano
2008-06-14 7:22 ` Jeff King
2008-06-14 7:25 ` [PATCH v2 1/5] " Jeff King
2008-06-14 7:26 ` [PATCH v2 2/5] mask necessary whitespace policy " Jeff King
2008-06-14 7:27 ` [PATCH v2 3/5] avoid whitespace on empty line in automatic usage message Jeff King
2008-06-14 7:27 ` [PATCH v2 4/5] avoid trailing whitespace in zero-change diffstat lines Jeff King
2008-06-14 7:28 ` [PATCH v2 5/5] enable whitespace checking of test scripts Jeff King
2008-06-14 6:54 ` [PATCH 2/4] mask necessary whitespace policy violations in " Jeff King
2008-06-14 6:56 ` [PATCH 3/4] avoid trailing whitespace in zero-change diffstat lines Jeff King
2008-06-14 7:22 ` Junio C Hamano
2008-06-14 7:30 ` Jeff King
2008-06-14 6:56 ` [PATCH 4/4] enable whitespace checking of test scripts Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080614064857.GA8930@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=lewiemann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).