git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Robin Rosenberg <robin.rosenberg@dewire.com>
To: Marek Zawirski <marek.zawirski@gmail.com>
Cc: "Shawn O. Pearce" <spearce@spearce.org>, git@vger.kernel.org
Subject: Re: [EGIT RFC] Commit behaviour
Date: Sat, 14 Jun 2008 12:23:10 +0200	[thread overview]
Message-ID: <200806141223.11134.robin.rosenberg@dewire.com> (raw)
In-Reply-To: <4852EFBF.6000406@gmail.com>

lördagen den 14 juni 2008 00.07.59 skrev Marek Zawirski:
> Theses patches don't work for me however :/ When I introduce some change 
> to a resource/file, even add it to index and click commit (toolbar or 
> menu), commit action does nothing. It is - nothing happens. Can you 
> reproduce this problem, or should I debug it on my instance? Or do I use 
> it in some wrong way?

Found it. Obviously this won't work for commits to multiple repositories which is supposed
to work really, but I think that was broken earlier by yours truly. This fix should make it
possible to test the idea though this thread is about, and see if we have more selection
problems. 

-- robin

diff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/actions/CommitAction.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/actions/CommitAction.java
index da32ea5..922649b 100644
--- a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/actions/CommitAction.java
+++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/actions/CommitAction.java
@@ -124,7 +124,7 @@ public class CommitAction extends RepositoryAction {
        }

        private void loadPreviousCommit() {
-               IProject project = getSelectedProjects()[0];
+               IProject project = getProjectsForSelectedResources()[0];

                Repository repo = RepositoryMapping.getMapping(project).getRepository();
                try {

  parent reply	other threads:[~2008-06-14 10:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-12 23:39 [EGIT RFC] Commit behaviour Robin Rosenberg
2008-06-12 23:39 ` [EGIT RFC] Add utilities for figuring out repositories for selected resources Robin Rosenberg
2008-06-12 23:39   ` [EGIT RFC] Enable commit for any resource in a Git-shared project Robin Rosenberg
2008-06-13 22:07 ` [EGIT RFC] Commit behaviour Marek Zawirski
2008-06-13 22:41   ` Marek Zawirski
2008-06-14  8:40     ` Robin Rosenberg
2008-06-14 10:05       ` Robin Rosenberg
2008-06-14  9:08   ` Robin Rosenberg
2008-06-14 10:23   ` Robin Rosenberg [this message]
2008-06-15  2:00     ` Marek Zawirski
2008-06-16  2:11 ` Shawn O. Pearce

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200806141223.11134.robin.rosenberg@dewire.com \
    --to=robin.rosenberg@dewire.com \
    --cc=git@vger.kernel.org \
    --cc=marek.zawirski@gmail.com \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).