git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Herland <johan@herland.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Matthieu Moy <Matthieu.Moy@imag.fr>,
	David Symonds <dsymonds@gmail.com>
Subject: [PATCH 3/3 v2] The "curl" executable is no longer required
Date: Sun, 15 Jun 2008 13:40:50 +0200	[thread overview]
Message-ID: <200806151340.50694.johan@herland.net> (raw)
In-Reply-To: <vpqmylnkkm4.fsf@bauges.imag.fr>

git-clone.sh was the last user of the "curl" executable. Relevant git
commands now use libcurl instead. This should be reflected in the
install requirements.

Signed-off-by: Johan Herland <johan@herland.net>
---

On Sunday 15 June 2008, Matthieu Moy wrote:
> I don't understand how that answers the question. Unless curl is
> statically linked, you need the library both at build time and at run
> time. For example, zlib-devel is needed here at build time, and zlib
> (without devel) is still in "Requires:". So, what's the difference
> between zlib and libcurl here?

You're probably right. What about this?

 INSTALL     |    8 ++++----
 git.spec.in |    2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/INSTALL b/INSTALL
index 9888f25..4a4e13f 100644
--- a/INSTALL
+++ b/INSTALL
@@ -67,10 +67,10 @@ Issues of note:
 	  that come with git (git includes the one from Mozilla, and has
 	  its own PowerPC and ARM optimized ones too - see the Makefile).
 
-	- "libcurl" and "curl" executable.  git-http-fetch and
-	  git-fetch use them.  If you do not use http
-	  transfer, you are probably OK if you do not have
-	  them.
+	- libcurl library; git-http-fetch and git-fetch use them.  You
+	  might also want the "curl" executable for debugging purposes.
+	  If you do not use http transfer, you are probably OK if you
+	  do not have them.
 
 	- expat library; git-http-push uses it for remote lock
 	  management over DAV.  Similar to "curl" above, this is optional.
diff --git a/git.spec.in b/git.spec.in
index 97a26be..fb8da85 100644
--- a/git.spec.in
+++ b/git.spec.in
@@ -12,7 +12,7 @@ BuildRequires:	zlib-devel >= 1.2, openssl-devel, curl-devel, expat-devel, gettex
 BuildRoot:	%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 
 Requires:	perl-Git = %{version}-%{release}
-Requires:	zlib >= 1.2, rsync, curl, less, openssh-clients, expat
+Requires:	zlib >= 1.2, rsync, libcurl, less, openssh-clients, expat
 Provides:	git-core = %{version}-%{release}
 Obsoletes:	git-core <= 1.5.4.2
 Obsoletes:	git-p4
-- 
1.5.6.rc2.128.gf64ae

  reply	other threads:[~2008-06-15 11:42 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-12  7:20 Cleaning up INSTALL before 1.5.6 Johan Herland
2008-06-15 10:13 ` [PATCH 1/3] cpio is no longer used by git-clone Johan Herland
2008-06-15 10:14 ` [PATCH 2/3] Consistency: Use "libcurl" instead of "cURL library" and "curl" Johan Herland
2008-06-15 10:16 ` [PATCH 3/3] The "curl" executable is no longer required Johan Herland
2008-06-15 10:52   ` David Symonds
2008-06-15 10:55     ` Johan Herland
2008-06-15 10:59       ` David Symonds
2008-06-15 11:23       ` Matthieu Moy
2008-06-15 11:40         ` Johan Herland [this message]
2008-06-15 11:42     ` Jakub Narebski
2008-06-15 11:47       ` Johan Herland
2008-06-15 12:04         ` Matthieu Moy
2008-06-15 13:33           ` Jakub Narebski
2008-06-15 13:53             ` Johan Herland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200806151340.50694.johan@herland.net \
    --to=johan@herland.net \
    --cc=Matthieu.Moy@imag.fr \
    --cc=dsymonds@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).